-
Notifications
You must be signed in to change notification settings - Fork 11.1k
chore: remove unused exports and redundant hook files #18681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @SandyTao520, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing codebase cleanliness and maintainability by systematically removing unused code and redundant files. The changes streamline the project by eliminating exports that were no longer consumed and removing entire files that had become obsolete, contributing to a more efficient and easier-to-understand codebase. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Hi @SandyTao520, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
|
Hi there! Thank you for your contribution to Gemini CLI. To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md. This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding How to link an issue: Thank you for your understanding and for being a part of our community! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully removes several unused exports and redundant hook files, as identified by ts-prune. The changes align perfectly with the stated goal of improving codebase cleanliness and maintainability. All removed code was confirmed to be unused, and no new issues were introduced. The PR is well-documented and the validation steps are clear.
|
Size Change: -1.04 kB (0%) Total Size: 23.9 MB
ℹ️ View Unchanged
|
Summary
This PR removes several unused exports and redundant hook files identified by
ts-pruneto improve codebase cleanliness and maintainability.Details
The following symbols were identified as unused exports and have been removed:
createSimulated429ErrorandresetSimulationStateinpackages/core/src/utils/testUtils.tsclearStringWidthCacheinpackages/cli/src/ui/utils/textUtils.tsansiSemanticColorsinpackages/cli/src/ui/themes/semantic-tokens.tsAdditionally, two redundant hook files that were not imported anywhere have been deleted:
packages/cli/src/ui/hooks/useRefreshMemoryCommand.tspackages/cli/src/ui/hooks/useShowMemoryCommand.tsThese files appeared to be old or redundant versions of functionality now handled by the subcommands in
memoryCommand.ts.Related Issues
#18007
How to Validate
npm run typecheckto ensure no type errors were introduced.npm run buildto ensure the project still builds successfully.npx ts-pruneto verify the removed symbols are no longer listed as unused exports.Pre-Merge Checklist