Skip to content

Conversation

@SandyTao520
Copy link
Contributor

@SandyTao520 SandyTao520 commented Feb 9, 2026

Summary

This PR removes several unused exports and redundant hook files identified by ts-prune to improve codebase cleanliness and maintainability.

Details

The following symbols were identified as unused exports and have been removed:

  • createSimulated429Error and resetSimulationState in packages/core/src/utils/testUtils.ts
  • clearStringWidthCache in packages/cli/src/ui/utils/textUtils.ts
  • ansiSemanticColors in packages/cli/src/ui/themes/semantic-tokens.ts

Additionally, two redundant hook files that were not imported anywhere have been deleted:

  • packages/cli/src/ui/hooks/useRefreshMemoryCommand.ts
  • packages/cli/src/ui/hooks/useShowMemoryCommand.ts

These files appeared to be old or redundant versions of functionality now handled by the subcommands in memoryCommand.ts.

Related Issues

#18007

How to Validate

  1. Run npm run typecheck to ensure no type errors were introduced.
  2. Run npm run build to ensure the project still builds successfully.
  3. (Optional) Run npx ts-prune to verify the removed symbols are no longer listed as unused exports.

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed) - N/A
  • Added/updated tests (if needed) - N/A
  • Noted breaking changes (if any) - None
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @SandyTao520, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing codebase cleanliness and maintainability by systematically removing unused code and redundant files. The changes streamline the project by eliminating exports that were no longer consumed and removing entire files that had become obsolete, contributing to a more efficient and easier-to-understand codebase.

Highlights

  • Code Cleanup: Removed several unused exports across different utility files, identified by ts-prune, to reduce dead code and improve maintainability.
  • File Deletion: Deleted two redundant hook files, useRefreshMemoryCommand.ts and useShowMemoryCommand.ts, which were no longer imported and their functionality is now handled elsewhere.
Changelog
  • packages/cli/src/ui/hooks/useRefreshMemoryCommand.ts
    • Removed the file as it was an unused hook.
  • packages/cli/src/ui/hooks/useShowMemoryCommand.ts
    • Removed the file as it was an unused hook, with its functionality now handled by subcommands in memoryCommand.ts.
  • packages/cli/src/ui/themes/semantic-tokens.ts
    • Removed the import of ansiTheme and the export of ansiSemanticColors as they were unused.
  • packages/cli/src/ui/utils/textUtils.ts
    • Removed the clearStringWidthCache export, which was no longer utilized.
  • packages/core/src/utils/testUtils.ts
    • Removed the createSimulated429Error and resetSimulationState exports, identified as unused test utilities.
Activity
  • The author has completed a pre-merge checklist, including validating on MacOS and confirming no documentation, tests, or breaking changes are needed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Feb 9, 2026

Hi @SandyTao520, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Feb 9, 2026

Hi there! Thank you for your contribution to Gemini CLI.

To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md.

This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding Fixes #123 or Related to #123), it will be automatically reopened.

How to link an issue:
Add a keyword followed by the issue number (e.g., Fixes #123) in the description of your pull request. For more details on supported keywords and how linking works, please refer to the GitHub Documentation on linking pull requests to issues.

Thank you for your understanding and for being a part of our community!

@gemini-cli gemini-cli bot closed this Feb 9, 2026
@SandyTao520 SandyTao520 reopened this Feb 9, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully removes several unused exports and redundant hook files, as identified by ts-prune. The changes align perfectly with the stated goal of improving codebase cleanliness and maintainability. All removed code was confirmed to be unused, and no new issues were introduced. The PR is well-documented and the validation steps are clear.

@github-actions
Copy link

github-actions bot commented Feb 9, 2026

Size Change: -1.04 kB (0%)

Total Size: 23.9 MB

Filename Size Change
./bundle/gemini.js 23.9 MB -1.04 kB (0%)
ℹ️ View Unchanged
Filename Size
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB
./bundle/sandbox-macos-permissive-open.sb 890 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB

compressed-size-action

@SandyTao520 SandyTao520 marked this pull request as ready for review February 9, 2026 22:08
@SandyTao520 SandyTao520 requested a review from a team as a code owner February 9, 2026 22:08
@gemini-cli gemini-cli bot added the status/need-issue Pull requests that need to have an associated issue. label Feb 9, 2026
@SandyTao520 SandyTao520 added this pull request to the merge queue Feb 9, 2026
Merged via the queue into main with commit 14219bb Feb 9, 2026
34 of 51 checks passed
@SandyTao520 SandyTao520 deleted the cleanup-unused-exports branch February 9, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants