Skip to content

Comments

chore: resolve build warnings and update dependencies#18880

Merged
mattKorwel merged 5 commits intomainfrom
mk-why-warnings
Feb 20, 2026
Merged

chore: resolve build warnings and update dependencies#18880
mattKorwel merged 5 commits intomainfrom
mk-why-warnings

Conversation

@mattKorwel
Copy link
Collaborator

Summary

This PR resolves several build and installation warnings related to unused ESLint directives and deprecated dependencies. It also updates core dependencies and fixes a resulting type error.

Details

  • Lint Warnings: Removed unused eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion warnings in packages/vscode-ide-companion.
  • Dependency Updates:
    • Updated @google/genai to 1.41.0 and google-auth-library to 10.5.0 in packages/core and packages/cli.
    • Added overrides in the root package.json for glob (^12.0.0) and node-domexception (^1.0.0) to suppress transitive deprecation warnings.
  • Type Fixes: Added missing FinishReason values (IMAGE_RECITATION, IMAGE_OTHER) to useGeminiStream.ts required by the @google/genai update.
  • ESLint Config: Updated root eslint.config.js to correctly target all packages, ensuring consistent linting for the VS Code companion.

Related Issues

N/A

How to Validate

  1. Run npm install and verify no deprecation warnings for glob or node-domexception appear.
  2. Run npm run build and verify it completes without warnings.
  3. Run npm run lint and verify it passes.
  4. Run npm run test and verify all tests pass.

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt

@mattKorwel mattKorwel requested review from a team as code owners February 12, 2026 06:02
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @mattKorwel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the project's stability and maintainability by resolving various build and linting warnings. It incorporates updated versions of key dependencies and introduces necessary type adjustments to accommodate these changes, ensuring a smoother development experience and consistent code quality across all modules.

Highlights

  • Build Warnings Resolved: Several build and installation warnings related to unused ESLint directives and deprecated dependencies have been addressed.
  • Dependency Updates: Core dependencies, including @google/genai and google-auth-library, have been updated across relevant packages. Overrides were added for glob and node-domexception to suppress transitive deprecation warnings.
  • Type Fixes: Missing FinishReason values (IMAGE_RECITATION, IMAGE_OTHER) required by the updated @google/genai library were added to useGeminiStream.ts.
  • ESLint Configuration: The root eslint.config.js was updated to correctly target all packages, ensuring consistent linting throughout the project, especially for the VS Code companion.
Changelog
  • eslint.config.js
    • Expanded ESLint configuration to apply to all packages, not just packages/cli.
  • package-lock.json
    • Removed old @google/genai and related transitive dependencies.
    • Added new transitive dependencies like is-network-error and p-retry.
    • Updated @google/genai and google-auth-library versions for packages/cli and packages/core.
    • Reflected updated dependency trees for @google/genai and google-auth-library within packages/cli and packages/core.
  • package.json
    • Introduced overrides for glob and node-domexception to suppress deprecation warnings.
  • packages/cli/package.json
    • Upgraded @google/genai dependency to version 1.41.0.
  • packages/cli/src/ui/hooks/useGeminiStream.ts
    • Included IMAGE_RECITATION and IMAGE_OTHER to the FinishReason enum to handle new Gemini stream termination reasons.
  • packages/core/package.json
    • Upgraded @google/genai dependency to version 1.41.0.
    • Upgraded google-auth-library dependency to version 10.5.0.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Comment on lines +928 to +931
[FinishReason.IMAGE_RECITATION]:
'Response stopped due to image recitation policy.',
[FinishReason.IMAGE_OTHER]:
'Response stopped due to other image-related reasons.',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to packages/cli/src/ui/hooks/useGeminiStream.ts was necessary because I updated the @google/genai dependency to version 1.41.0.

This update introduced two new values to the FinishReason enum: IMAGE_RECITATION and IMAGE_OTHER. Since the finishReasonMessages object in that file is typed as a strict Record<FinishReason, string |
undefined>, TypeScript threw a type error because the new reasons were missing from the mapping.

I added the following entries to resolve the type error and ensure the build succeeds:

[FinishReason.IMAGE_RECITATION]: 'Response stopped due to image recitation policy.',
[FinishReason.IMAGE_OTHER]: 'Response stopped due to other image-related reasons.',

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively resolves several build and installation warnings by updating dependencies and removing unused ESLint directives. The changes are well-contained and address the described issues, such as adding missing FinishReason enum values to fix type errors resulting from the @google/genai update and expanding the ESLint configuration to cover all packages. The use of overrides in package.json to suppress transitive dependency warnings is a good practice. Overall, these are solid maintenance improvements.

@gemini-cli gemini-cli bot added the status/need-issue Pull requests that need to have an associated issue. label Feb 12, 2026
@mattKorwel mattKorwel enabled auto-merge February 20, 2026 00:16
@github-actions
Copy link

Size Change: +576 kB (+2.35%)

Total Size: 25.1 MB

Filename Size Change
./bundle/gemini.js 25.1 MB +576 kB (+2.35%)
ℹ️ View Unchanged
Filename Size
./bundle/sandbox-macos-permissive-open.sb 890 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB
./bundle/sandbox-macos-strict-open.sb 4.82 kB
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB

compressed-size-action

@mattKorwel mattKorwel added this pull request to the merge queue Feb 20, 2026
Merged via the queue into main with commit c3b52b8 Feb 20, 2026
27 checks passed
@mattKorwel mattKorwel deleted the mk-why-warnings branch February 20, 2026 03:36
theerud pushed a commit to theerud/gemini-cli that referenced this pull request Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants