Skip to content

fix(patch): cherry-pick e5ff202 to release/v0.29.0-preview.3-pr-19254 to patch version v0.29.0-preview.3 and create version 0.29.0-preview.4#19264

Merged
skeshive merged 1 commit intorelease/v0.29.0-preview.3-pr-19254from
hotfix/v0.29.0-preview.3/0.29.0-preview.4/preview/cherry-pick-e5ff202/pr-19254
Feb 17, 2026
Merged

fix(patch): cherry-pick e5ff202 to release/v0.29.0-preview.3-pr-19254 to patch version v0.29.0-preview.3 and create version 0.29.0-preview.4#19264
skeshive merged 1 commit intorelease/v0.29.0-preview.3-pr-19254from
hotfix/v0.29.0-preview.3/0.29.0-preview.4/preview/cherry-pick-e5ff202/pr-19254

Conversation

@gemini-cli-robot
Copy link
Collaborator

This PR automatically cherry-picks commit e5ff202 to patch version v0.29.0-preview.3 in the preview release to create version 0.29.0-preview.4.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request cherry-picks a fix to update the cycling order of approval modes within the CLI, ensuring that the Shift+Tab shortcut behaves as intended. It includes corresponding documentation updates, refactors UI text into a centralized constant, and migrates related unit tests to snapshot testing for improved reliability.

Highlights

  • Approval Mode Cycle Order: The order of cycling through approval modes (Default, Auto-Edit, Plan) using the Shift+Tab keyboard shortcut has been updated. The new cycle is Default -> Auto-Edit -> Plan.
  • Documentation Update: The documentation for the CLI's plan mode has been updated to reflect the new keyboard shortcut cycle order.
  • UI Text Centralization: Text strings used in the ApprovalModeIndicator component have been extracted into a shared constant for better maintainability and consistency.
  • Snapshot Testing Migration: Unit tests for the ApprovalModeIndicator component have been refactored to utilize snapshot testing, improving test robustness for UI rendering.
Changelog
  • docs/cli/plan-mode.md
    • Corrected the keyboard shortcut cycle order for approval modes in the documentation.
  • packages/cli/src/ui/components/ApprovalModeIndicator.test.tsx
    • Refactored approval mode indicator tests to use snapshot testing for rendering output.
    • Removed explicit toContain assertions in favor of snapshot comparisons.
  • packages/cli/src/ui/components/ApprovalModeIndicator.tsx
    • Introduced a new constant APPROVAL_MODE_TEXT to centralize text strings for approval mode indicators.
    • Updated the ApprovalModeIndicator component to use the newly defined APPROVAL_MODE_TEXT constants.
  • packages/cli/src/ui/components/snapshots/ApprovalModeIndicator.test.tsx.snap
    • Added snapshot test results for the ApprovalModeIndicator component.
  • packages/cli/src/ui/hooks/useApprovalModeIndicator.test.ts
    • Adjusted test cases to reflect the updated Shift+Tab cycling order for approval modes.
    • Updated comments to accurately describe the new cycle flow.
  • packages/cli/src/ui/hooks/useApprovalModeIndicator.ts
    • Modified the logic that determines the next approval mode when Shift+Tab is pressed, changing the cycle order from Default -> Plan -> Auto-Edit to Default -> Auto-Edit -> Plan.
Activity
  • This pull request was automatically created to cherry-pick commit e5ff202 to patch version v0.29.0-preview.3 and create version 0.29.0-preview.4.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link

Size Change: +457 B (0%)

Total Size: 23.9 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 23.9 MB +457 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cherry-picks a fix that changes the cycling order of approval modes. The changes are implemented consistently across the application logic, UI component text, tests, and documentation. The logic in useApprovalModeIndicator.ts is correctly updated to reflect the new cycle: Default -> Auto-Edit -> Plan. The corresponding UI hints in ApprovalModeIndicator.tsx are also updated and refactored to use constants, which improves maintainability. The tests have been updated to use snapshots and verify the new behavior. Overall, this is a solid change with no apparent issues.

@skeshive skeshive enabled auto-merge (squash) February 17, 2026 17:19
@gemini-cli gemini-cli bot added the status/need-issue Pull requests that need to have an associated issue. label Feb 17, 2026
@skeshive skeshive merged commit 13249bc into release/v0.29.0-preview.3-pr-19254 Feb 17, 2026
27 checks passed
@skeshive skeshive deleted the hotfix/v0.29.0-preview.3/0.29.0-preview.4/preview/cherry-pick-e5ff202/pr-19254 branch February 17, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants