fix(patch): cherry-pick e5ff202 to release/v0.29.0-preview.3-pr-19254 to patch version v0.29.0-preview.3 and create version 0.29.0-preview.4#19264
Conversation
Summary of ChangesHello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request cherry-picks a fix to update the cycling order of approval modes within the CLI, ensuring that the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Size Change: +457 B (0%) Total Size: 23.9 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Code Review
This pull request cherry-picks a fix that changes the cycling order of approval modes. The changes are implemented consistently across the application logic, UI component text, tests, and documentation. The logic in useApprovalModeIndicator.ts is correctly updated to reflect the new cycle: Default -> Auto-Edit -> Plan. The corresponding UI hints in ApprovalModeIndicator.tsx are also updated and refactored to use constants, which improves maintainability. The tests have been updated to use snapshots and verify the new behavior. Overall, this is a solid change with no apparent issues.
13249bc
into
release/v0.29.0-preview.3-pr-19254
This PR automatically cherry-picks commit e5ff202 to patch version v0.29.0-preview.3 in the preview release to create version 0.29.0-preview.4.