feat(cli): replace loading phrases boolean with enum setting#19347
feat(cli): replace loading phrases boolean with enum setting#19347
Conversation
Replace the binary `ui.accessibility.enableLoadingPhrases` toggle with a new `ui.loadingPhrases` enum setting supporting four modes: `tips`, `witty`, `all`, and `off`. The default changes from `all` to `tips`, showing only informative tips while the model is working. - Add `loadingPhrases` enum to settings schema with `tips | witty | all | off` - Migrate `enableLoadingPhrases: false` → `loadingPhrases: 'off'` - Wire `customWittyPhrases` setting through to `usePhraseCycler` - Update Composer to read from settings instead of deprecated config - Regenerate settings docs and JSON schema
Summary of ChangesHello @LyalinDotCom, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user experience by providing granular control over loading phrases within the CLI. By transitioning from a simple on/off toggle to an enum-based setting, users can now choose between informative tips, witty comments, a combination of both, or disable them entirely. This change also activates the previously dormant custom witty phrases feature and includes a seamless migration for existing user settings, ensuring a smoother and more personalized interaction with the CLI. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new enum setting ui.loadingPhrases to replace the old boolean toggle, providing more granular control over the loading phrases shown in the UI. The changes are well-implemented across the board, including updates to the settings schema, migration logic for existing users, comprehensive tests, and documentation. The new default behavior of showing only tips is a sensible choice for a quieter user experience. The implementation of the usePhraseCycler hook is now cleaner and correctly handles the different modes, including the use of custom witty phrases. Overall, this is a solid improvement to the CLI's user experience and configuration.
|
Size Change: +1.27 kB (+0.01%) Total Size: 24.5 MB
ℹ️ View Unchanged
|
|
@jacob314 can you review please as discussed. I did not add the notification of the feature in this PR figured we can do that as a separate follow-up PR? |
gemini-cli
bot
added
priority/p2
|
Heads up: while rebasing/merging this branch onto the latest I tested a If link-check flakes continue after this lands, we should handle it in a separate follow-up PR (e.g., update that doc link to a more stable target or add a narrowly-scoped lychee exclusion). |
| default: true, | ||
| description: 'Enable loading phrases during operations.', | ||
| showInDialog: true, | ||
| description: |
There was a problem hiding this comment.
love that you set showInDialog to false for this.
2 participants
Summary
ui.accessibility.enableLoadingPhrasestoggle with a newui.loadingPhrasesenum setting supporting four modes: tips, witty, all, and offcustomWittyPhrasessetting so it actually takes effectenableLoadingPhrases: false→loadingPhrases: 'off'so users who disabled phrases keep their preferenceResolves #14942
Test plan
npm run build:all— no type errorsusePhraseCycler.test.tsx— 16 tests pass (new tests for each mode)useLoadingIndicator.test.tsx— 8 tests pass (newoffmode test)Composer.test.tsx— 55 tests pass (updated to use new setting)settings.test.ts— 94 tests pass (3 new migration tests)settingsSchema.test.ts— enum property test addednpm run lint— clean, no warnings/settingsshows the new enum, default istips, cycling works,offhides phrases