fix(cli): support legacy onConfirm callback in ToolActionsContext

[SandyTao520]

Summary

Fixes a bug where tool confirmations without a correlationId (specifically custom slash commands) would hang because the local onConfirm callback was ignored.

Details

Custom commands using the legacy confirmation style rely on a local onConfirm callback instead of the newer MessageBus-based confirmation system. ToolActionsContext.tsx was only handling MessageBus responses, causing these clicks to be dropped.

Changes:

• Added a hasLegacyCallback type guard to safely check for the presence of the onConfirm callback.
• Updated the confirm function in ToolActionsContext.tsx to call the legacy callback as a fallback when no correlationId is present.
• Added a unit test in ToolActionsContext.test.tsx to verify the fix and prevent regressions.

Related Issues

Reported in chat by user dutidMKN7NY. Related to #18007

How to Validate

1. Run unit tests:

   cd gemini-cli && npm test -w @google/gemini-cli -- src/ui/contexts/ToolActionsContext.test.tsx

2. Run a full build to ensure no type/lint regressions:

   cd gemini-cli && npm run build:all

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
  • Windows
  • Linux
    • npm run

[gemini-cli]

Hi @SandyTao520, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

[gemini-cli]

Hi there! Thank you for your contribution to Gemini CLI.

To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md.

This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding Fixes #123 or Related to #123), it will be automatically reopened.

How to link an issue:
Add a keyword followed by the issue number (e.g., Fixes #123) in the description of your pull request. For more details on supported keywords and how linking works, please refer to the GitHub Documentation on linking pull requests to issues.

Thank you for your understanding and for being a part of our community!

[gemini-code-assist]

Summary of Changes

Hello @SandyTao520, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug that prevented legacy tool actions, particularly custom slash commands, from being confirmed correctly. By implementing a fallback mechanism to invoke local onConfirm callbacks when a correlationId is absent, the change ensures that all tool interactions, regardless of their confirmation style, are processed reliably within the CLI.

Highlights

• Bug Fix: Resolved an issue where tool confirmations without a correlationId (e.g., custom slash commands) would hang due to ignored local onConfirm callbacks.
• Legacy Callback Support: Introduced a hasLegacyCallback type guard and updated the confirm function in ToolActionsContext.tsx to correctly invoke legacy onConfirm callbacks as a fallback when no correlationId is present.
• Test Coverage: Added a new unit test in ToolActionsContext.test.tsx to validate the fix and prevent regressions for legacy confirmation handling.

Changelog

• packages/cli/src/ui/contexts/ToolActionsContext.test.tsx
  • Imported SerializableConfirmationDetails type.
  • Added a new test case to verify that the local onConfirm callback is called for tools without a correlationId.
• packages/cli/src/ui/contexts/ToolActionsContext.tsx
  • Imported SerializableConfirmationDetails type.
  • Defined LegacyConfirmationDetails type to include an optional onConfirm callback.
  • Implemented hasLegacyCallback type guard function to check for the presence of a legacy callback.
  • Modified the confirm function to check for and invoke the legacy onConfirm callback if no correlationId is present.
  • Updated a warning message to reflect the new fallback logic for missing correlation IDs or callbacks.

Activity

• The author, SandyTao520, provided a detailed summary of the bug, its solution, and validation steps.
• The author confirmed that new tests were added and updated.
• The author validated the changes on Linux using npm run.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Code Review

This pull request effectively addresses a bug where legacy tool confirmations were being ignored by adding a fallback to the onConfirm callback in ToolActionsContext. The logic is sound, and the addition of a unit test in ToolActionsContext.test.tsx is excellent for preventing regressions. I have one suggestion to improve the type safety of the new type guard function, which will make the code more robust.

[github-actions]

Size Change: +270 B (0%)

Total Size: 24.5 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	24.5 MB	+270 B (0%)
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B
./bundle/sandbox-macos-strict-open.sb	4.82 kB	0 B
./bundle/sandbox-macos-strict-proxied.sb	5.02 kB	0 B

_{compressed-size-action}