Search updates

[alisa-alisa]

Summary

Updates for the search tool.

Details

Updated search tool + added evals for it.

Related Issues

Closes #17544

How to Validate

Validation same as added in the evals.

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-code-assist]

Summary of Changes

Hello @alisa-alisa, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the search capabilities by introducing new evaluation tests for the grep_search tool, ensuring its robustness across different scenarios. Additionally, it improves the clarity of the grep_search_ripgrep tool's description, highlighting its optimized performance and recommending its usage for more efficient file content searching.

Highlights

• New Evaluation Tests: Added a comprehensive set of evaluation tests for the grep_search tool, covering various search functionalities like case sensitivity, file name only results, include globs, subdirectory searches, and handling of no matches.
• Tool Description Enhancement: Updated the description for the grep_search_ripgrep tool to clearly state its performance advantages, powered by ripgrep, and recommend its use over standard grep for better efficiency and automatic output limiting.

Changelog

• evals/grep_search_functionality.eval.ts
  • Added new evaluation tests for the grep_search tool.
• packages/core/src/tools/definitions/snapshots/coreToolsModelSnapshots.test.ts.snap
  • Updated the snapshot for the grep_search_ripgrep tool's description.
• packages/core/src/tools/definitions/model-family-sets/gemini-3.ts
  • Updated the description for the grep_search_ripgrep tool.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Size Change: +236 B (0%)

Total Size: 24.5 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	24.5 MB	+236 B (0%)
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B
./bundle/sandbox-macos-strict-open.sb	4.82 kB	0 B
./bundle/sandbox-macos-strict-proxied.sb	5.02 kB	0 B

_{compressed-size-action}

[gemini-code-assist]

Code Review

This pull request introduces evaluation tests for the grep_search tool and updates its description to guide the model towards using the more performant ripgrep-based implementation. The new tests are comprehensive and cover various tool parameters, which is a great addition. However, I've identified an inconsistency in the new tool description regarding the match limits, which could confuse the model. My review includes suggestions to align the documentation for clarity and correctness.