fix(core): treat 503 Service Unavailable as retryable quota error#19642
fix(core): treat 503 Service Unavailable as retryable quota error#19642
Conversation
|
Hi @sehoon38, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello @sehoon38, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the error handling mechanism by treating 503 Service Unavailable responses as retryable quota errors. This change improves the system's robustness by allowing automatic retries for temporary service interruptions, aligning their treatment with existing rate limit error handling. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Hi there! Thank you for your contribution to Gemini CLI. To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md. This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding How to link an issue: Thank you for your understanding and for being a part of our community! |
There was a problem hiding this comment.
Code Review
The pull request correctly identifies and addresses the need to treat 503 Service Unavailable errors as retryable quota errors. The changes include modifying classifyGoogleError to handle status code 503 and adding a corresponding unit test. The code changes are well-implemented and the test case adequately covers the new functionality.
|
Size Change: +309 B (0%) Total Size: 25.1 MB ℹ️ View Unchanged
|
Summary
Treat 503 Service Unavailable as a retryable quota error in
classifyGoogleError. This ensures that temporary service interruptions are handled similarly to rate limits, allowing the system to retry the operation instead of failing immediately.Details
classifyGoogleErrorinpackages/core/src/utils/googleQuotaErrors.tsto check for status code 503.RetryableQuotaError.packages/core/src/utils/googleQuotaErrors.test.ts.Related Issues
Fixes #19656
How to Validate
Run
npm test -w @google/gemini-cli-core -- src/utils/googleQuotaErrors.test.tsto verify the new test case.Pre-Merge Checklist