Skip to content

Comments

fix(cli): re-enable CLI banner#19741

Merged
sehoon38 merged 1 commit intomainfrom
fix/re-enable-banner-19737
Feb 20, 2026
Merged

fix(cli): re-enable CLI banner#19741
sehoon38 merged 1 commit intomainfrom
fix/re-enable-banner-19737

Conversation

@sehoon38
Copy link
Contributor

@sehoon38 sehoon38 commented Feb 20, 2026

Summary

Re-enables the CLI banner text for standard cases (no capacity issues) in the UI.

Details

The dummy empty string that temporarily disabled the banner in AppContainer.tsx has been removed, restoring config.getBannerTextNoCapacityIssues().

Related Issues

Fixes #19737

How to Validate

  1. Start the CLI using npm start
  2. Ensure you see the banner text during initialization.

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@sehoon38 sehoon38 requested review from a team as code owners February 20, 2026 22:01
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @sehoon38, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily re-activates the command-line interface banner display, which was previously suppressed. This change ensures that users will once again see important banner messages during CLI initialization under normal operating conditions. Additionally, the project's dependency lock file has been updated to reflect changes in peer dependency metadata and a new utility package.

Highlights

  • CLI Banner Re-enabled: The temporary disabling of the CLI banner text in AppContainer.tsx has been reverted, restoring the display of config.getBannerTextNoCapacityIssues() for standard cases.
  • Dependency Metadata Update: The package-lock.json file was updated to include peer: true for several packages and to add strip-json-comments as a new dependency.
Changelog
  • package-lock.json
    • Added peer: true metadata to numerous package entries, including @modelcontextprotocol/sdk, @octokit/rest, @opentelemetry/api, @opentelemetry/core, @opentelemetry/resources, @opentelemetry/sdk-metrics, @opentelemetry/sdk-trace-base, @types/react, @typescript-eslint/eslint-plugin, acorn, eslint, express, hono, ink, react, react-dom, picomatch, tslib, tsx, typescript, vite, vitest, and zod.
    • Introduced a new dependency, strip-json-comments.
  • packages/cli/src/ui/AppContainer.tsx
    • Restored the call to config.getBannerTextNoCapacityIssues() to re-enable the CLI banner text, removing the temporary empty string placeholder.
Activity
  • The pull request was opened by sehoon38.
  • The author provided a detailed summary, explanation of changes, related issue (Fixes Re-enable CLI Banner #19737), and validation steps.
  • Validation on MacOS using npm run has been marked as completed in the pre-merge checklist.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@sehoon38 sehoon38 force-pushed the fix/re-enable-banner-19737 branch from 11dfa80 to fffec05 Compare February 20, 2026 22:04
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request re-enables the CLI banner text and updates the package lock file with peer dependency metadata. While the changes restore intended functionality, there are robustness concerns regarding asynchronous operations on startup and a dependency inconsistency in the lock file.

I am having trouble creating individual review comments. Click here to see my feedback.

packages/cli/src/ui/AppContainer.tsx (2081)

high

The asynchronous call to getBannerTextNoCapacityIssues() (and the subsequent call to getBannerTextCapacityIssues()) lacks error handling. If these calls fail—for instance, due to network issues or if the config object is not yet fully initialized—it will result in an unhandled promise rejection. In Node.js 20+, this can cause the CLI process to terminate unexpectedly on startup. It is recommended to wrap these calls in a try-catch block or add a .catch() handler with a safe fallback. Additionally, consider ensuring config.isInitialized() is true before making these calls to avoid race conditions.

        config.getBannerTextNoCapacityIssues().catch(() => ''),

package-lock.json (17446)

high

The dependency strip-json-comments has been added to the packages/core section of the lock file, but the corresponding change to packages/core/package.json is missing from this pull request. This inconsistency can lead to the dependency being removed during future npm install runs or causing build failures in environments that rely on package.json as the source of truth. Please ensure that the package.json file is updated and included in the PR.

@sehoon38 sehoon38 removed the request for review from a team February 20, 2026 22:05
@sehoon38 sehoon38 enabled auto-merge February 20, 2026 22:06
@scidomino
Copy link
Collaborator

Update the description to remove references to package.json updates

@github-actions
Copy link

Size Change: -37 B (0%)

Total Size: 25.2 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 25.2 MB -37 B (0%)
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B

compressed-size-action

@gemini-cli gemini-cli bot added the area/core Issues related to User Interface, OS Support, Core Functionality label Feb 20, 2026
@sehoon38 sehoon38 added this pull request to the merge queue Feb 20, 2026
Merged via the queue into main with commit b746524 Feb 20, 2026
28 checks passed
@sehoon38 sehoon38 deleted the fix/re-enable-banner-19737 branch February 20, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-enable CLI Banner

2 participants