fix: merge duplicate imports in a2a-server package (2/4)#19781
fix: merge duplicate imports in a2a-server package (2/4)#19781scidomino merged 10 commits intogoogle-gemini:mainfrom
Conversation
Consolidate duplicate import statements from the same modules to comply with the import/no-duplicates ESLint rule. Changes: - Merged duplicate imports from '@google/gemini-cli-core' in multiple files - Merged duplicate imports from '../types.js' in agent files - Merged duplicate imports from '@a2a-js/sdk/server' in task.ts - Merged duplicate imports from 'vitest' in gcs.test.ts This is part 2 of 4 PRs to clean up import/no-duplicates warnings across the codebase (10 files in a2a-server package).
Summary of ChangesHello @Nixxx19, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving code quality and adherence to ESLint rules by consolidating duplicate import statements within the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly consolidates duplicate import statements across multiple files in the packages/a2a-server directory. The changes are straightforward, improve code cleanliness, and align with the stated goal of fixing the import/no-duplicates ESLint rule. The implementation is sound, and I see no issues with the proposed refactoring.
…hub.com/Nixxx19/gemini-cli into nityam/cleanup-import-no-duplicates-a2a
Summary
This PR consolidates duplicate import statements from the same modules to comply with the
import/no-duplicatesESLint rule.Part 2 of 4 - Fixes 10 files in
packages/a2a-serverChanges
@google/gemini-cli-corein multiple files../types.jsin agent files@a2a-js/sdk/serverintask.tsvitestingcs.test.tsTesting
Related
packages/sdk+packages/test-utils(5 files)packages/core(145 files)packages/cli(207 files)