feat(core): remove unnecessary login verbiage from Code Assist auth

[NTaylorMullen]

Summary

Removes the unnecessary "Code Assist Login required" verbiage from the login dialog and OAuth flow.

Details

• Modified packages/core/src/code_assist/oauth2.ts to remove redundant login required messages.
• Updated packages/core/src/utils/authConsent.ts to handle empty prompts gracefully (preventing leading spaces).
• Added a unit test in packages/core/src/utils/authConsent.test.ts to verify empty prompt handling.

Related Issues

Related to internal request for UI simplification.

How to Validate

1. Run the unit tests: npm test -w @google/gemini-cli-core -- src/utils/authConsent.test.ts src/code_assist/oauth2.test.ts
2. Manually trigger a login flow (e.g., by clearing credentials or using a new environment) and observe the consent prompt and browser message.

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-code-assist]

Summary of Changes

Hello @NTaylorMullen, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the user authentication experience by eliminating repetitive 'Code Assist login required' messages from both the login dialog and the OAuth flow. It also improves the prompt handling logic to ensure cleaner messages when no specific prompt text is provided, enhancing overall UI clarity and user interaction during the authentication process.

Highlights

• Authentication Verbiage Removal: Removed redundant 'Code Assist login required' messages from the authentication flow, simplifying the user experience.
• Empty Prompt Handling Improvement: Enhanced the consent utility to gracefully handle empty prompts, preventing unnecessary leading spaces in generated messages.
• New Unit Test: Added a unit test to specifically verify the correct behavior of empty authentication prompts.

Changelog

• packages/core/src/code_assist/oauth2.ts
  • Removed the 'Code Assist login required.' string passed to the getConsentForOauth function.
  • Removed the 'Code Assist login required.' line from the UserFeedback message emitted during the authentication process.
• packages/core/src/utils/authConsent.test.ts
  • Added a new test case to verify that getConsentForOauth correctly formats the prompt when an empty string is passed, ensuring it starts with 'Opening authentication page in your browser.'.
• packages/core/src/utils/authConsent.ts
  • Modified the finalPrompt construction in getConsentForOauth to conditionally add a space after the prompt variable only if prompt is not empty, preventing leading spaces.

Activity

• Added a new unit test to cover empty prompt handling.
• Validated changes on MacOS using npm run.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively removes redundant "Code Assist Login required" text from the authentication flow, which simplifies the user experience. The changes are well-implemented across the board. The modification to getConsentForOauth to gracefully handle empty prompt strings is a good defensive measure, and it's great to see a new unit test added to verify this behavior. The changes are clear, focused, and improve the UI messaging. Overall, this is a solid improvement.

[github-actions]

Size Change: -36 B (0%)

Total Size: 25.2 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	25.2 MB	-36 B (0%)
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B
./bundle/sandbox-macos-strict-open.sb	4.82 kB	0 B
./bundle/sandbox-macos-strict-proxied.sb	5.02 kB	0 B

_{compressed-size-action}