feat(cli): unify /chat and /resume command UX#20256
Conversation
Summary of ChangesHello @LyalinDotCom, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the command-line interface by unifying the Highlights
Changelog
ActivityUsing Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Size Change: +4.96 kB (+0.02%) Total Size: 26 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Code Review
This pull request successfully unifies the user experience for the /chat and /resume commands by making /chat an alias and introducing a new grouped menu for subcommands. The changes are comprehensive, covering documentation, command definitions, UI components, and the underlying completion logic. The implementation appears solid and is well-supported by both updated and newly added tests. I did not identify any issues of high or critical severity in this review.
jacob314
left a comment
There was a problem hiding this comment.
Code Review
Summary
This PR elegantly unifies the /chat and /resume commands, aligning their UX and enabling the grouped sub-command features. The implementation is solid and well-tested.
Findings
- Correctness: The integration of the shared
chatResumeSubCommandsinto both commands is clean. The update toBuiltinCommandLoadersafely injects thedebugsubcommand for nightly builds across the new shared hierarchy, including thecheckpointshidden alias. - Maintainability: The use of
suggestionGroupcleanly separates the domain of command definitions from UI presentation (sectionTitleinSuggestionsDisplay). - User Experience: The special-case prefix descent for
chatandresumeinuseSlashCompletion.tsis a nice touch to eliminate friction during the phase-one alias UX. The specialautosection suggestion also acts as a great entry point. - Testing: Test coverage was updated appropriately, and the logic around the
checkpointscompatibility layer and rendering grouped suggestions is fully covered.
Conclusion
Approved. Excellent work on simplifying and unifying the session management commands!
Summary
/chatand/resumeinto one alias-based chat surface for phase one.listentry selectable and keep prefix behavior consistent (for example/resu).Validation
npm test -w @google/gemini-cli -- src/ui/commands/chatCommand.test.ts src/ui/commands/resumeCommand.test.ts src/services/BuiltinCommandLoader.test.ts src/ui/components/SuggestionsDisplay.test.tsx src/ui/hooks/useSlashCompletion.test.tsnpm test -w @google/gemini-cli -- src/ui/hooks/useSlashCompletion.test.ts src/ui/hooks/useCommandCompletion.test.tsx src/ui/components/InputPrompt.test.tsxnpm run typecheck -w @google/gemini-cliCloses #20255