fix(theme): update default theme colors for improved contrast#21169
fix(theme): update default theme colors for improved contrast#21169
Conversation
|
Hi there! Thank you for your contribution to Gemini CLI. To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md. This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding How to link an issue: Thank you for your understanding and for being a part of our community! |
|
Hi @clocky, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the accessibility and legibility of the CLI's themes by adjusting color palettes for both light and dark modes. The changes are specifically designed to meet contrast ratio standards in xterm-256 compatible terminal emulators, particularly macOS Terminal.app, ensuring a more comfortable and compliant user experience. A new utility script has also been added to facilitate the validation and preview of these color changes. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Fixes #21170 |
There was a problem hiding this comment.
Code Review
This pull request significantly improves the accessibility and contrast of the default light and dark themes by updating their color definitions to meet a minimum 4.5:1 contrast ratio, especially for xterm-256 environments like macOS Terminal.app. A new script scripts/preview-dark-theme.ts has been added to aid in validating these color changes. However, there's a critical inconsistency in how these colors are handled, which might undermine the PR's primary goal.
Summary
Updates both light and dark theme colors to ensure a minimum 4.5:1 contrast ratio in xterm-256 environments, specifically targeting improved visibility and accessibility for macOS Terminal.app.
Details
Related Issues
Fixes #21170