Skip to content

fix(theme): update default theme colors for improved contrast#21169

Closed
clocky wants to merge 2 commits intomainfrom
fix/256-color-contrast
Closed

fix(theme): update default theme colors for improved contrast#21169
clocky wants to merge 2 commits intomainfrom
fix/256-color-contrast

Conversation

@clocky
Copy link
Contributor

@clocky clocky commented Mar 4, 2026

Summary

Updates both light and dark theme colors to ensure a minimum 4.5:1 contrast ratio in xterm-256 environments, specifically targeting improved visibility and accessibility for macOS Terminal.app.

Details

  • Adjusted darkTheme colors to meet 4.5:1 contrast standards against the default black background.
  • Adjusted lightTheme colors to meet 4.5:1 contrast standards against the default white/light-gray background.
  • Scope: This PR only targets the default darkTheme and lightTheme definitions; no other themes (e.g., Ayu, GitHub, Solarized) are affected.

Related Issues

Fixes #21170

@clocky clocky requested a review from a team as a code owner March 4, 2026 22:03
@gemini-cli
Copy link
Contributor

gemini-cli bot commented Mar 4, 2026

Hi there! Thank you for your contribution to Gemini CLI.

To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md.

This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding Fixes #123 or Related to #123), it will be automatically reopened.

How to link an issue:
Add a keyword followed by the issue number (e.g., Fixes #123) in the description of your pull request. For more details on supported keywords and how linking works, please refer to the GitHub Documentation on linking pull requests to issues.

Thank you for your understanding and for being a part of our community!

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Mar 4, 2026

Hi @clocky, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

@gemini-cli gemini-cli bot closed this Mar 4, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the accessibility and legibility of the CLI's themes by adjusting color palettes for both light and dark modes. The changes are specifically designed to meet contrast ratio standards in xterm-256 compatible terminal emulators, particularly macOS Terminal.app, ensuring a more comfortable and compliant user experience. A new utility script has also been added to facilitate the validation and preview of these color changes.

Highlights

  • Improved Theme Contrast: Updated both light and dark theme colors to ensure a minimum 4.5:1 contrast ratio, specifically targeting improved visibility and accessibility in xterm-256 environments like macOS Terminal.app.
  • New Theme Preview Script: Introduced a new script to preview theme colors, calculate their contrast ratios, and display their closest xterm-256 approximations, aiding in visual verification and accessibility compliance.
Changelog
  • packages/cli/src/ui/themes/theme.ts
    • Updated color definitions for lightTheme to improve contrast and simplify color assignments.
    • Updated color definitions for darkTheme to improve contrast and simplify color assignments.
    • Removed interpolateColor function calls for direct hex color assignments.
  • scripts/preview-dark-theme.ts
    • Added a new script to preview theme colors and their contrast ratios.
    • Implemented logic to find the closest xterm-256 color approximation for given hex values.
    • Included functions to rate contrast levels (AAA, AA, LG, FAIL) for better accessibility insights.
Activity
  • The author has validated the changes on MacOS using 'npm run'.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@clocky clocky added the 🔒 maintainer only ⛔ Do not contribute. Internal roadmap item. label Mar 4, 2026
@clocky
Copy link
Contributor Author

clocky commented Mar 4, 2026

Fixes #21170

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly improves the accessibility and contrast of the default light and dark themes by updating their color definitions to meet a minimum 4.5:1 contrast ratio, especially for xterm-256 environments like macOS Terminal.app. A new script scripts/preview-dark-theme.ts has been added to aid in validating these color changes. However, there's a critical inconsistency in how these colors are handled, which might undermine the PR's primary goal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔒 maintainer only ⛔ Do not contribute. Internal roadmap item.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(theme): improve theme color contrast for macOS Terminal.app

1 participant