docs: document tool exclusion from memory via deny policy#21428
docs: document tool exclusion from memory via deny policy#21428g-samroberts merged 3 commits intomainfrom
Conversation
…and note deprecation of excludeTools
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the documentation for the policy engine, providing crucial clarity on how Highlights
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Size Change: -4 B (0%) Total Size: 26 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for the policy engine. It clarifies that global deny rules also remove tools from the model's memory, and it adds a note deprecating the legacy excludeTools setting. While the added details are helpful, the deprecation note is ambiguous as there are multiple settings for excluding tools (tools.exclude, mcpServers.<serverName>.excludeTools). The high-severity comment addressing this ambiguity has been kept as it aligns with the rule for maintaining consistency in documentation, preventing potential user confusion and security misconfigurations.
Note: Security Review has been skipped due to the limited scope of the PR.
Summary
This PR updates the policy engine documentation to explain that global
denyrules exclude tools from the model's memory (function declarations). It also notes the deprecation of the legacyexcludeToolssetting.Details
docs/reference/policy-engine.mdabout howdenydecisions impact tool visibility for the model.excludeToolsinsettings.jsonis deprecated in favor of the Policy Engine'sdenyrules.packages/core/src/tools/tool-registry.tsthatgetActiveToolscorrectly filters these tools.Related Issues
Closes #21427
How to Validate
docs/reference/policy-engine.md.denydecisions correctly describes the memory exclusion behavior.excludeToolsis clear.Pre-Merge Checklist