fix(core): display actual graph output in tracker_visualize tool#21455
fix(core): display actual graph output in tracker_visualize tool#21455
Conversation
|
Hi @anj-s, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
|
Size Change: -15 B (0%) Total Size: 26 MB ℹ️ View Unchanged
|
|
Hi there! Thank you for your contribution to Gemini CLI. To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md. This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding How to link an issue: Thank you for your understanding and for being a part of our community! |
|
Thank you for linking an issue! This pull request has been automatically reopened. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the usability of the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
Upon review against repository-specific rules, the identified Cross-Site Scripting (XSS) vulnerability in the returnDisplay field is not considered relevant for CLI tool output displayed in a user's terminal, as per Rule 2. This rule states that XSS is not a relevant vulnerability for plain text output in a CLI tool's terminal, as it lacks a browser context for script execution. Therefore, no security comments are retained from the original review.
Summary
Fixes the
tracker_visualizetool so that the generated task dependency graph is returned for user display, instead of the hardcoded string "Graph rendered."Details
Previously, the
TrackerVisualizeInvocationreturned the graph correctly to the LLM viallmContent, but masked the output in the UI usingreturnDisplay: 'Graph rendered.'. This changes thereturnDisplayvalue to the actualoutputstring so the user can see the graph structure in their terminal.Related Issues
Fixes #21456
How to Validate
tracker_visualizetool or ask the agent to visualize the tracker.Pre-Merge Checklist