Conversation
|
Hi @sehoon38, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
|
Hi there! Thank you for your contribution to Gemini CLI. To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md. This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding How to link an issue: Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new /upgrade command to the CLI, providing a direct way for users to upgrade their Gemini Code Assist tier. The implementation is solid: the command is conditionally registered based on the user's authentication method, and the action securely opens the upgrade URL in the browser. The changes are well-tested and documented. The code adheres to the project's existing patterns and includes appropriate safety checks. I have not identified any high or critical issues in this pull request.
|
Thank you for linking an issue! This pull request has been automatically reopened. |
|
Size Change: +678 B (0%) Total Size: 26 MB ℹ️ View Unchanged
|
Address PR comment regarding an unnecessary return statement. Also adds a unit test for the /upgrade command.
- Add explicit return to satisfy noImplicitReturns. - Use valid AuthType enum value in tests.
Summary
This PR implements the
/upgradeslash command in the Gemini CLI. This command provides a direct way for users to upgrade their Gemini Code Assist tier to access higher usage limits.Details
UPGRADE_URL_PAGEand fallback handler functions to make them accessible to the CLI.upgradeCommandwhich opens the upgrade URL in the user's default browser./upgradecommand is only registered and visible to the user if they are authenticated via Google (AuthType.LOGIN_WITH_GOOGLE), consistent with existing UI logic in the ProQuotaDialog./upgradecommand to the CLI command reference.BuiltinCommandLoader.test.tsto ensure the command is only included when the appropriate authentication type is active.Related Issues
Fixes #21513
How to Validate
GEMINI_API_KEY)./and verify/upgradeis not in the list of suggestions./and verify/upgradeis visible./upgrade.https://goo.gle/set-up-gemini-code-assist).npm test -w @google/gemini-cli -- src/services/BuiltinCommandLoader.test.tsand verify all tests pass.Pre-Merge Checklist