Skip to content

feat(cli): add foundational configuration schema for multimodal voice mode#21651

Open
frostbyte012 wants to merge 1 commit intogoogle-gemini:mainfrom
frostbyte012:feat/voice-settings-schema
Open

feat(cli): add foundational configuration schema for multimodal voice mode#21651
frostbyte012 wants to merge 1 commit intogoogle-gemini:mainfrom
frostbyte012:feat/voice-settings-schema

Conversation

@frostbyte012
Copy link

Description

This PR introduces the foundational configuration schema for the Hands-Free Multimodal Voice Mode (GSoC 2026 Idea 11).

By integrating these settings into the core settingsSchema.ts, the CLI can now persistently store user preferences for voice interaction without impacting current text-based workflows. This follows the project's monorepo architecture and leverages the existing deep-merge logic for User and Workspace settings.

Changes

  • Added voice configuration block to SETTINGS_SCHEMA in packages/cli/src/config/settingsSchema.ts.
  • Defined properties: enabled (boolean), inputDevice (string), vadSensitivity (number), and ttsVoice (enum).
  • Updated auto-generated JSON schemas in schemas/settings.schema.json.
  • Regenerated documentation via npm run docs:settings.

Testing Done

Verified build via npm run build.

Confirmed schema inference in the configuration engine.

Ran npm run docs:settings to ensure documentation consistency across the monorepo.

Related Issue

Fixes #21649

@frostbyte012 frostbyte012 requested review from a team as code owners March 8, 2026 22:11
@google-cla
Copy link

google-cla bot commented Mar 8, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request establishes the foundational configuration schema for the planned Hands-Free Multimodal Voice Mode. By integrating new voice-related settings into the core configuration, it enables persistent storage of user preferences for voice interaction without affecting existing text-based functionalities, aligning with the project's monorepo architecture and leveraging existing configuration management.

Highlights

  • Configuration Schema Addition: Introduced a new "voice" configuration block within the SETTINGS_SCHEMA to support the upcoming Hands-Free Multimodal Voice Mode.
  • Voice Settings Definition: Defined specific properties for voice interaction, including "enabled", "inputDevice", "vadSensitivity", and "ttsVoice", with appropriate types and default values.
  • Documentation and Schema Regeneration: Updated the auto-generated JSON schemas and documentation (docs/cli/settings.md, docs/reference/configuration.md) to reflect the new voice configuration options.
Changelog
  • docs/cli/settings.md
    • Added a new "Voice" section to the CLI settings documentation, detailing the new voice-related configuration options and their defaults.
  • docs/reference/configuration.md
    • Included a new "voice" section in the comprehensive configuration reference, providing detailed descriptions, types, and default values for each voice setting.
  • packages/cli/src/config/settingsSchema.ts
    • Integrated the "voice" configuration object into the main SETTINGS_SCHEMA, defining its properties, labels, categories, default values, and descriptions for voice mode settings.
  • schemas/settings.schema.json
    • Updated the auto-generated JSON schema to include the new "voice" configuration block and its associated properties, ensuring schema validation for voice settings.
Activity
  • No human activity (comments, reviews, etc.) has occurred on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the foundational configuration schema for the new multimodal voice mode. The changes are well-structured and add the necessary settings to settingsSchema.ts, along with updating the auto-generated JSON schema and documentation.

I've found one high-severity issue related to an inconsistency in the requiresRestart flag for the new voice settings group, which could lead to incorrect behavior regarding application restarts. My detailed comment provides a suggestion for resolving this.

type: 'object',
label: 'Voice Mode',
category: 'Experimental',
requiresRestart: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

There's an inconsistency in the requiresRestart flags for the new voice settings. The parent voice object is marked with requiresRestart: true, while some of its properties (vadSensitivity and ttsVoice) are correctly marked with requiresRestart: false.

This conflicts with the pattern used in other settings groups like general and ui, where the parent object has requiresRestart: false and only the specific properties that need a restart are marked as such. This inconsistency can lead to confusion and potential bugs in how restart requirements are determined.

To align with the existing architecture and ensure clarity, the parent voice object's requiresRestart flag should be false.

Suggested change
requiresRestart: true,
requiresRestart: false,

@frostbyte012
Copy link
Author

@google-cla-bot check

@frostbyte012 frostbyte012 force-pushed the feat/voice-settings-schema branch from de8a04f to bd3cf49 Compare March 10, 2026 22:24
@frostbyte012
Copy link
Author

@google-cla-bot check

@frostbyte012 frostbyte012 force-pushed the feat/voice-settings-schema branch from 5c077db to 7912089 Compare March 10, 2026 22:38
@frostbyte012 frostbyte012 requested a review from a team as a code owner March 10, 2026 22:38
@frostbyte012 frostbyte012 force-pushed the feat/voice-settings-schema branch from c50fe8c to 34c2478 Compare March 10, 2026 23:01
@frostbyte012
Copy link
Author

CLA is signed and verified. I have squashed the commits into a single clean feature commit and resolved all previous schema inconsistencies. Ready for CI checks and review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Add configuration schema for Hands-Free Multimodal Voice Mode

1 participant