docs: fix misleading YOLO mode description in defaultApprovalMode#21878
Conversation
The documentation incorrectly stated 'yolo is not supported yet' when in fact YOLO mode is fully supported - it just cannot be set as the default approval mode in settings.json for security reasons. Updated the description to clarify that YOLO mode can only be enabled via command line flags (--yolo or --approval-mode=yolo).
|
@Gyanranjan-Priyam please open an issue for this and link it to this PR |
|
@jerop Kindly recheck the PR and also I create an issue and linked it to the PR. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an inaccuracy in the documentation for the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly updates the documentation for the general.defaultApprovalMode setting across multiple files. The previous description was misleading, stating that YOLO mode was not supported. The new description accurately clarifies that YOLO mode is fully functional but can only be enabled via command-line flags for security reasons. The changes are consistent in the settings schema source file and all generated documentation files. The pull request is well-focused and resolves the documented issue effectively.
99bbbc2
…ogle-gemini#21878) Co-authored-by: Adib234 <30782825+Adib234@users.noreply.github.com> Co-authored-by: A.K.M. Adib <adibakm@google.com>
…ogle-gemini#21878) Co-authored-by: Adib234 <30782825+Adib234@users.noreply.github.com> Co-authored-by: A.K.M. Adib <adibakm@google.com>
…ogle-gemini#21878) Co-authored-by: Adib234 <30782825+Adib234@users.noreply.github.com> Co-authored-by: A.K.M. Adib <adibakm@google.com>
Summary
Fixes #21883
Fixes incorrect/misleading documentation that stated "yolo is not supported yet" when YOLO mode is actually fully supported.
Problem
The documentation for
general.defaultApprovalModesetting incorrectly stated:This was misleading because YOLO mode is fully functional. The setting does not include
yoloas an option because it is intentionally excluded from being set as a default insettings.jsonfor security reasons—not because the feature does not exist.Solution
Updated the description to accurately explain that:
--yoloor--approval-mode=yolo) for security reasonsChanges
settingsSchema.tswith the corrected descriptionsettings.schema.json,docs/cli/settings.md, anddocs/reference/configuration.mdTesting
All existing tests pass.