fix(patch): cherry-pick 3ff68a9 to release/v0.33.0-preview.14-pr-21884 [CONFLICTS]#21952
Conversation
# Conflicts: # package-lock.json # packages/core/package.json
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is an automated cherry-pick aimed at patching a specific release version, primarily addressing a critical Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Resolved merge conflicts in package-lock.json.
There was a problem hiding this comment.
Code Review
This pull request aims to fix a dependency issue by cherry-picking a commit that downgrades @google/genai and related packages. While the intent is correct, there's a critical merge conflict in packages/core/package.json that needs to be resolved. I've also identified a potential logic issue in the new check-lockfile.js script that could undermine its purpose of preventing this dependency problem in the future.
I am having trouble creating individual review comments. Click here to see my feedback.
packages/core/package.json (28-33)
This file contains unresolved merge conflict markers (<<<<<<<, =======, >>>>>>>). These markers must be removed, and the conflict resolved before merging. Based on the PR's intent to fix a dependency issue, you should select the version that downgrades @google/genai and adds @grpc/grpc-js.
"@google/genai": "1.30.0",
"@grpc/grpc-js": "^1.14.3",scripts/check-lockfile.js (83)
This condition !location.includes('@google/genai/node_modules') creates a loophole in the check. The goal is to prevent gaxios@>=7 from being introduced, which is often a transitive dependency of @google/genai. If @google/genai is upgraded and brings in a problematic version of gaxios, this condition will cause the check to ignore it, defeating its purpose. This line should be removed to ensure all instances of gaxios are validated.
|
Size Change: -255 kB (-0.98%) Total Size: 25.6 MB
ℹ️ View Unchanged
|
This PR automatically cherry-picks commit 3ff68a9 to patch version v0.33.0-preview.14 in the preview release to create version 0.33.0-preview.15.
This cherry-pick resulted in merge conflicts that need manual resolution.
🔧 Next Steps:
📋 Files with conflicts:
The commit has been created with conflict markers for easier manual resolution.
🚨 Important: