Skip to content

Introduce a config module to manage configuration#22

Merged
rakyll merged 2 commits intomainfrom
config
Apr 18, 2025
Merged

Introduce a config module to manage configuration#22
rakyll merged 2 commits intomainfrom
config

Conversation

@rakyll
Copy link
Copy Markdown
Contributor

@rakyll rakyll commented Apr 18, 2025

It'd be good to have a config module like this to have a central place to manage configuration. Will finish it and send it.

cc @evansenter, this is a follow up to the comments I left on your earlier change.

@rakyll rakyll force-pushed the config branch 3 times, most recently from afedfd1 to 4a064ac Compare April 18, 2025 18:00
@rakyll rakyll marked this pull request as ready for review April 18, 2025 18:00
Copy link
Copy Markdown
Collaborator

@NTaylorMullen NTaylorMullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@NTaylorMullen
Copy link
Copy Markdown
Collaborator

Oh just realized this may break some of the manual tslint changes that just went in. You'll probably have to rebase

@rakyll
Copy link
Copy Markdown
Contributor Author

rakyll commented Apr 18, 2025

Rebased!

@rakyll rakyll merged commit 3afaa80 into main Apr 18, 2025
2 checks passed
@rakyll rakyll deleted the config branch April 18, 2025 18:12
evansenter pushed a commit that referenced this pull request Apr 18, 2025
* Introduce a config module to manage configuration

* Remove public modifier
keithballinger pushed a commit that referenced this pull request Jun 13, 2025
* Introduce a config module to manage configuration
* Remove public modifier
yaleh pushed a commit to yaleh/gemini-cli that referenced this pull request Jun 29, 2025
* Introduce a config module to manage configuration

* Remove public modifier
viridivn pushed a commit to viridivn/gemini-cli that referenced this pull request Jun 29, 2025
* Introduce a config module to manage configuration

* Remove public modifier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants