fix(core): use dynamic CLI version for IDE client instead of hardcoded '1.0.0'#24414
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the IdeClient to dynamically retrieve and report the current CLI version instead of using a hardcoded placeholder. This change ensures better compatibility tracking and resolves a long-standing TODO item, improving the reliability of the IDE integration. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request updates the IdeClient in packages/core to dynamically retrieve the CLI version using getVersion() instead of using a hardcoded '1.0.0' string for both the streamable HTTP and stdio clients. This change successfully addresses existing TODOs regarding versioning. I have no feedback to provide as there were no review comments to evaluate.
|
Hi there! Thank you for your interest in contributing to Gemini CLI. To ensure we maintain high code quality and focus on our prioritized roadmap, we have updated our contribution policy (see Discussion #17383). We only guarantee review and consideration of pull requests for issues that are explicitly labeled as 'help wanted'. All other community pull requests are subject to closure after 14 days if they do not align with our current focus areas. For this reason, we strongly recommend that contributors only submit pull requests against issues explicitly labeled as 'help-wanted'. This pull request is being closed as it has been open for 14 days without a 'help wanted' designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding and for being part of our community! |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the IdeClient in packages/core to dynamically retrieve the version using getVersion() instead of using a hardcoded '1.0.0' string for both the streamable HTTP and stdio clients. This change addresses a TODO item to align the client version with the CLI version. I have no feedback to provide as there were no review comments.
Resolves #24413
Description:
Currently, the
IdeClientinitialization inpackages/core/src/ide/ide-client.tshardcodes theversionstring to'1.0.0'in both HTTP and STDIO connection establishment methods. These lines are marked with// TODO(#3487): use the CLI version here.. This hardcoding prevents the IDE client from properly reporting its actual integration version, which could cause compatibility checking issues down the line.Expected Behavior:
The IDE client should report the actual, dynamic version of the Gemini CLI when establishing connections, resolving TODO #3487.