Skip to content

fix(core): use dynamic CLI version for IDE client instead of hardcoded '1.0.0'#24414

Merged
cynthialong0-0 merged 3 commits intogoogle-gemini:mainfrom
thekishandev:fix/ide-client-version
Apr 22, 2026
Merged

fix(core): use dynamic CLI version for IDE client instead of hardcoded '1.0.0'#24414
cynthialong0-0 merged 3 commits intogoogle-gemini:mainfrom
thekishandev:fix/ide-client-version

Conversation

@thekishandev
Copy link
Copy Markdown
Contributor

Resolves #24413

Description:
Currently, the IdeClient initialization in packages/core/src/ide/ide-client.ts hardcodes the version string to '1.0.0' in both HTTP and STDIO connection establishment methods. These lines are marked with // TODO(#3487): use the CLI version here.. This hardcoding prevents the IDE client from properly reporting its actual integration version, which could cause compatibility checking issues down the line.

Expected Behavior:
The IDE client should report the actual, dynamic version of the Gemini CLI when establishing connections, resolving TODO #3487.

@thekishandev thekishandev requested a review from a team as a code owner April 1, 2026 11:05
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the IdeClient to dynamically retrieve and report the current CLI version instead of using a hardcoded placeholder. This change ensures better compatibility tracking and resolves a long-standing TODO item, improving the reliability of the IDE integration.

Highlights

  • Dynamic Versioning: Replaced the hardcoded '1.0.0' version string with a dynamic call to getVersion() in the IdeClient initialization.
  • TODO Resolution: Resolved the pending TODO fix: correct mcp client name and version #3487 by implementing the required CLI version reporting in both HTTP and STDIO connection methods.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Apr 1, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the IdeClient in packages/core to dynamically retrieve the CLI version using getVersion() instead of using a hardcoded '1.0.0' string for both the streamable HTTP and stdio clients. This change successfully addresses existing TODOs regarding versioning. I have no feedback to provide as there were no review comments to evaluate.

@gemini-cli gemini-cli Bot added the area/core Issues related to User Interface, OS Support, Core Functionality label Apr 1, 2026
@gemini-cli
Copy link
Copy Markdown
Contributor

gemini-cli Bot commented Apr 16, 2026

Hi there! Thank you for your interest in contributing to Gemini CLI.

To ensure we maintain high code quality and focus on our prioritized roadmap, we have updated our contribution policy (see Discussion #17383).

We only guarantee review and consideration of pull requests for issues that are explicitly labeled as 'help wanted'. All other community pull requests are subject to closure after 14 days if they do not align with our current focus areas. For this reason, we strongly recommend that contributors only submit pull requests against issues explicitly labeled as 'help-wanted'.

This pull request is being closed as it has been open for 14 days without a 'help wanted' designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding and for being part of our community!

@gemini-cli gemini-cli Bot closed this Apr 16, 2026
@cynthialong0-0
Copy link
Copy Markdown
Contributor

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the IdeClient in packages/core to dynamically retrieve the version using getVersion() instead of using a hardcoded '1.0.0' string for both the streamable HTTP and stdio clients. This change addresses a TODO item to align the client version with the CLI version. I have no feedback to provide as there were no review comments.

@gemini-cli gemini-cli Bot added the help wanted We will accept PRs from all issues marked as "help wanted". Thanks for your support! label Apr 22, 2026
@cynthialong0-0 cynthialong0-0 added this pull request to the merge queue Apr 22, 2026
Merged via the queue into google-gemini:main with commit 0758a5e Apr 22, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality help wanted We will accept PRs from all issues marked as "help wanted". Thanks for your support!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(core): use dynamic CLI version for IDE client instead of hardcoded '1.0.0'

2 participants