Conversation
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly upgrades the Gemini CLI DevTools by integrating robust filtering and search functionalities across its console and network panels. Users can now efficiently narrow down logs and network requests using regular expressions, case-sensitive searches, and specific toggles for log levels, HTTP methods, and status codes. These enhancements, combined with visual highlighting of search results and an improved server auto-start mechanism, aim to provide a more intuitive and productive debugging experience. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
I've made the required changes, do take a look when time permits! |
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive search and filtering system for the DevTools client, featuring regex support, case sensitivity, and inverted filtering for both console and network logs. It adds persistent log level selection for the console and method/status class filtering for network requests, along with a keyboard shortcut for quick filter access. Review feedback highlights a critical concern regarding the auto-start logic in the DevTools entry point, which could lead to unintended server execution when the module is imported, and suggests performance optimizations for log rendering to prevent UI lag during filtering.
Note: Security Review is unavailable for this PR.
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
|
@sehoon38 I used the /code-reviewer skill today for the first time, and it did flag some parts of the code which I corrected (refer last commit) this is a v good skill! |
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
Summary
Changes have been made to enhance debugging productivity using the Gemini CLI DevTools.
Enhancements include:
Details
FilterBarcomponent. Search inputs will now dynamically drill down url logs (in console, and network tab). Users can also make use of RegEx for their searches. Network methods, and Status Codes are also filterable (only appear as required).npm run startand this seemed to be the fix.Before
Console
Network Tab
After
Console
Network Tab
Related Issues
This PR addresses #21993
How to Validate
Pre-Merge Checklist