feat(core): enable topic update narration by default and promote to general#25586
feat(core): enable topic update narration by default and promote to general#25586gundermanc merged 2 commits intomainfrom
Conversation
Co-authored-by: Jack Wotherspoon <jackwoth@google.com>
🛑 Action Required: Evaluation ApprovalSteering changes have been detected in this PR. To prevent regressions, a maintainer must approve the evaluation run before this PR can be merged. Maintainers:
Once approved, the evaluation results will be posted here automatically. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request promotes the Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request promotes the 'Topic & Update Narration' feature from an experimental setting to a general configuration setting. It updates the relevant configuration schemas, documentation, and CLI configuration loading logic to reflect this change, while also updating existing evaluation tests to use the new configuration path. Additionally, a minor UI fix was included to close the theme dialog when quitting the application. I have no further feedback to provide.
gundermanc
force-pushed
the
gundermanc/enable-by-default
branch
from
7f680af to
d5cf754
Compare
gemini-cli
Bot
added
the
status/need-issue
|
Size Change: +321 B (0%) Total Size: 33.6 MB
ℹ️ View Unchanged
|
…eneral (#25586)
Co-authored-by: JAYADITYA <96861162+JayadityaGit@users.noreply.github.com> Co-authored-by: Jack Wotherspoon <jackwoth@google.com>
## Summary
<!-- Concisely describe what this PR changes and why. Focus on impact and
urgency. -->
## Details
<!-- Add any extra context and design decisions. Keep it brief but complete. -->
## Related Issues
<!-- Use keywords to auto-close issues (Closes #123, Fixes #456). If this PR is
only related to an issue or is a partial fix, simply reference the issue number
without a keyword (Related to #123). -->
## How to Validate
<!-- List exact steps for reviewers to validate the change. Include commands,
expected results, and edge cases. -->
## Pre-Merge Checklist
<!-- Check all that apply before requesting review or merging. -->
- [ ] Updated relevant documentation and README (if needed)
- [ ] Added/updated tests (if needed)
- [ ] Noted breaking changes (if any)
- [ ] Validated on required platforms/methods:
- [ ] MacOS
- [ ] npm run
- [ ] npx
- [ ] Docker
- [ ] Podman
- [ ] Seatbelt
- [ ] Windows
- [ ] npm run
- [ ] npx
- [ ] Docker
- [ ] Linux
- [ ] npm run
- [ ] npx
- [ ] Docker
3 participants
Summary
This PR enables the
topicUpdateNarrationsetting by default and moves it from theexperimentalcategory to thegeneralcategory, as it is now ready for wider use.Details
packages/core/src/config/config.tsto defaulttopicUpdateNarrationtotrueand read fromsettings.general.topicUpdateNarrationwith a fallback tosettings.experimental.topicUpdateNarration.packages/cli/src/config/settingsSchema.tsandschemas/settings.schema.jsonto move the setting to thegeneralblock and set the default totrue.docs/cli/settings.mdanddocs/reference/configuration.md.evals/update_topic.eval.tsto reflect the newgeneralsetting location.Related Issues
How to Validate
topicUpdateNarrationin your.gemini/settings.json.Pre-Merge Checklist