fix(cli): handle DECKPAM keypad Enter sequences in terminal#26092
fix(cli): handle DECKPAM keypad Enter sequences in terminal#26092spencer426 merged 3 commits intogoogle-gemini:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a functional gap in the CLI's terminal input handling, specifically for Linux environments using VS Code's integrated terminal. By mapping the missing escape sequence for the Numpad Enter key, the change ensures that input from the numeric keypad is correctly interpreted and submitted. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
4edd7c7
Summary
Fix issue where the Numpad
Enterkey fails to work in VS Code Linux integrated terminals running in Application Keypad Mode (DECKPAM).Details
Other numeric keypad characters were correctly mapped via
NUMPAD_MAP, butEnter(\eOM) was missing as it doesn't represent a text character directly. MapsOMtoenterwithinKEY_INFO_MAP.Related Issues
Resolves #22671
How to Validate
Using VS Code on Linux in integrated terminal, press Numpad numbers and Numpad Enter; verify input registers and is submitted.
Pre-Merge Checklist