Skip to content

fix(cli): handle DECKPAM keypad Enter sequences in terminal#26092

Merged
spencer426 merged 3 commits intogoogle-gemini:mainfrom
Gitanaskhan26:fix/numpad-deckpam-enter
Apr 28, 2026
Merged

fix(cli): handle DECKPAM keypad Enter sequences in terminal#26092
spencer426 merged 3 commits intogoogle-gemini:mainfrom
Gitanaskhan26:fix/numpad-deckpam-enter

Conversation

@Gitanaskhan26
Copy link
Copy Markdown
Contributor

Summary

Fix issue where the Numpad Enter key fails to work in VS Code Linux integrated terminals running in Application Keypad Mode (DECKPAM).

Details

Other numeric keypad characters were correctly mapped via NUMPAD_MAP, but Enter (\eOM) was missing as it doesn't represent a text character directly. Maps OM to enter within KEY_INFO_MAP.

Related Issues

Resolves #22671

How to Validate

Using VS Code on Linux in integrated terminal, press Numpad numbers and Numpad Enter; verify input registers and is submitted.

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
    • Windows
    • Linux

@Gitanaskhan26 Gitanaskhan26 requested a review from a team as a code owner April 28, 2026 04:19
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a functional gap in the CLI's terminal input handling, specifically for Linux environments using VS Code's integrated terminal. By mapping the missing escape sequence for the Numpad Enter key, the change ensures that input from the numeric keypad is correctly interpreted and submitted.

Highlights

  • Keypad Enter Support: Added the 'OM' sequence to the KEY_INFO_MAP to correctly handle the Numpad Enter key when in Application Keypad Mode (DECKPAM).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the KEY_INFO_MAP in KeypressContext.tsx to include a mapping for the 'OM' sequence to the 'enter' key name. I have no feedback to provide.

@gemini-cli gemini-cli Bot added area/core Issues related to User Interface, OS Support, Core Functionality help wanted We will accept PRs from all issues marked as "help wanted". Thanks for your support! labels Apr 28, 2026
Copy link
Copy Markdown
Contributor

@spencer426 spencer426 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spencer426 spencer426 enabled auto-merge April 28, 2026 20:52
@spencer426 spencer426 added this pull request to the merge queue Apr 28, 2026
Merged via the queue into google-gemini:main with commit 4edd7c7 Apr 28, 2026
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality help wanted We will accept PRs from all issues marked as "help wanted". Thanks for your support!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Numeric Keypad (NumLock) unresponsive in VS Code Integrated Terminal (Linux Fedora KDE Plasma)

2 participants