Skip to content

feat(cli): support @-mentioning files in AskUser custom input#26465

Open
Adib234 wants to merge 4 commits intomainfrom
adibakm/ask-user-file
Open

feat(cli): support @-mentioning files in AskUser custom input#26465
Adib234 wants to merge 4 commits intomainfrom
adibakm/ask-user-file

Conversation

@Adib234
Copy link
Copy Markdown
Contributor

@Adib234 Adib234 commented May 4, 2026

Summary

Enable users to reference specific files using @ mentioning within the AskUserDialog's text inputs (both for text-type questions and the custom "Other" option in choice questions).

Details

  • Created a reusable AutocompleteTextInput component that wraps TextInput and provides @ completion capabilities.
  • Integrated useCommandCompletion and SuggestionsDisplay to provide the same file-search experience available in the main prompt.
  • Updated AskUserDialog.tsx to use AutocompleteTextInput instead of the standard TextInput.
  • Added eslint suppression for a mock CommandContext required by the completion hook.

Related Issues

Fixes #18495

How to Validate

  1. Run the CLI and trigger an interaction that uses AskUser with a text input (e.g., providing feedback on a plan).
  2. Type @ followed by a partial path.
  3. Verify that the file suggestions list appears.
  4. Use arrow keys to navigate and Tab or Enter to select a file.

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run

@Adib234 Adib234 requested review from a team as code owners May 4, 2026 20:42
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

Size Change: +3.05 kB (+0.01%)

Total Size: 34 MB

Filename Size Change
./bundle/chunk-2FYZLGZO.js 0 B -14.7 MB (removed) 🏆
./bundle/chunk-2MLCQYIU.js 0 B -3.43 kB (removed) 🏆
./bundle/chunk-6DHHNIXI.js 0 B -2.78 MB (removed) 🏆
./bundle/chunk-7DI4UAL6.js 0 B -19.5 kB (removed) 🏆
./bundle/chunk-GEBXPFA6.js 0 B -49.2 kB (removed) 🏆
./bundle/chunk-L2OLO656.js 0 B -658 kB (removed) 🏆
./bundle/chunk-NGHAFHYE.js 0 B -12.5 kB (removed) 🏆
./bundle/chunk-TMUJBMM7.js 0 B -3.8 kB (removed) 🏆
./bundle/core-7VDBELN5.js 0 B -48.7 kB (removed) 🏆
./bundle/devtoolsService-EVVM3TTM.js 0 B -28 kB (removed) 🏆
./bundle/gemini-73AHUN36.js 0 B -583 kB (removed) 🏆
./bundle/interactiveCli-BJ5ZUZGL.js 0 B -1.29 MB (removed) 🏆
./bundle/liteRtServerManager-WZ5RGPME.js 0 B -2.11 kB (removed) 🏆
./bundle/oauth2-provider-HSPEWCTQ.js 0 B -9.16 kB (removed) 🏆
./bundle/chunk-4MEBA7FK.js 3.43 kB +3.43 kB (new file) 🆕
./bundle/chunk-AMBKJ53D.js 49.2 kB +49.2 kB (new file) 🆕
./bundle/chunk-GGXQJNQ5.js 12.5 kB +12.5 kB (new file) 🆕
./bundle/chunk-KO3NCEE6.js 658 kB +658 kB (new file) 🆕
./bundle/chunk-OERFSQ7N.js 2.78 MB +2.78 MB (new file) 🆕
./bundle/chunk-OHXFZPHT.js 14.7 MB +14.7 MB (new file) 🆕
./bundle/chunk-OJQYVXTX.js 19.5 kB +19.5 kB (new file) 🆕
./bundle/chunk-RBR3RRMI.js 3.8 kB +3.8 kB (new file) 🆕
./bundle/core-RCVSNHSP.js 48.7 kB +48.7 kB (new file) 🆕
./bundle/devtoolsService-VDG7LPNK.js 28 kB +28 kB (new file) 🆕
./bundle/gemini-VAJ4ERZB.js 583 kB +583 kB (new file) 🆕
./bundle/interactiveCli-224WE35M.js 1.29 MB +1.29 MB (new file) 🆕
./bundle/liteRtServerManager-XPWKL7EC.js 2.11 kB +2.11 kB (new file) 🆕
./bundle/oauth2-provider-VYDJHGYV.js 9.16 kB +9.16 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./bundle/bundled/third_party/index.js 8 MB 0 B
./bundle/chunk-34MYV7JD.js 2.45 kB 0 B
./bundle/chunk-5AUYMPVF.js 858 B 0 B
./bundle/chunk-5PS3AYFU.js 1.18 kB 0 B
./bundle/chunk-664ZODQF.js 124 kB 0 B
./bundle/chunk-DAHVX5MI.js 206 kB 0 B
./bundle/chunk-ECNYAST2.js 1.97 MB 0 B
./bundle/chunk-IUUIT4SU.js 56.5 kB 0 B
./bundle/chunk-RJTRUG2J.js 39.8 kB 0 B
./bundle/cleanup-D7NOHH5C.js 0 B -932 B (removed) 🏆
./bundle/devtools-36NN55EP.js 696 kB 0 B
./bundle/dist-T73EYRDX.js 356 B 0 B
./bundle/events-XB7DADIJ.js 418 B 0 B
./bundle/examples/hooks/scripts/on-start.js 188 B 0 B
./bundle/examples/mcp-server/example.js 1.43 kB 0 B
./bundle/gemini.js 5.1 kB 0 B
./bundle/getMachineId-bsd-TXG52NKR.js 1.55 kB 0 B
./bundle/getMachineId-darwin-7OE4DDZ6.js 1.55 kB 0 B
./bundle/getMachineId-linux-SHIFKOOX.js 1.34 kB 0 B
./bundle/getMachineId-unsupported-5U5DOEYY.js 1.06 kB 0 B
./bundle/getMachineId-win-6KLLGOI4.js 1.72 kB 0 B
./bundle/memoryDiscovery-FB7MMKTA.js 980 B 0 B
./bundle/multipart-parser-KPBZEGQU.js 11.7 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 222 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 229 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 13.4 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B
./bundle/src-QVCVGIUX.js 47 kB 0 B
./bundle/start-DDL5MGZA.js 0 B -652 B (removed) 🏆
./bundle/tree-sitter-7U6MW5PS.js 274 kB 0 B
./bundle/tree-sitter-bash-34ZGLXVX.js 1.84 MB 0 B
./bundle/cleanup-3YBL5J7U.js 932 B +932 B (new file) 🆕
./bundle/start-YO7YDW75.js 652 B +652 B (new file) 🆕

compressed-size-action

@gemini-cli gemini-cli Bot added area/core Issues related to User Interface, OS Support, Core Functionality area/agent Issues related to Core Agent, Tools, Memory, Sub-Agents, Hooks, Agent Quality 🔒 maintainer only ⛔ Do not contribute. Internal roadmap item. labels May 4, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the CLI user experience by enabling file referencing through @-mentioning within AskUserDialog inputs. By creating a new AutocompleteTextInput component, the changes provide a consistent and intuitive way for users to select files directly within text prompts, improving workflow efficiency and usability.

Highlights

  • New Autocomplete Component: Introduced a reusable AutocompleteTextInput component that wraps the standard TextInput to provide file-mentioning capabilities via @.
  • Enhanced AskUser Dialog: Updated AskUserDialog.tsx to utilize the new AutocompleteTextInput for both standard text questions and custom input options.
  • Integration: Integrated useCommandCompletion and SuggestionsDisplay to ensure a consistent file-search experience across the CLI.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the AutocompleteTextInput component to provide file-path suggestions in the CLI's dialog views, replacing the standard TextInput in AskUserDialog. The feedback highlights that the package-lock.json contains numerous unintended dependency changes that should be reverted. Additionally, the AutocompleteTextInput component uses an unsafe type assertion for CommandContext which could lead to runtime errors, and the suggestion display mode should be dynamically adjusted based on its position (above vs. below) to ensure a correct user experience.

Comment thread package-lock.json Outdated
Comment thread packages/cli/src/ui/components/shared/AutocompleteTextInput.tsx Outdated
Comment thread packages/cli/src/ui/components/shared/AutocompleteTextInput.tsx Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/agent Issues related to Core Agent, Tools, Memory, Sub-Agents, Hooks, Agent Quality area/core Issues related to User Interface, OS Support, Core Functionality 🔒 maintainer only ⛔ Do not contribute. Internal roadmap item.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support @-mentioning files in AskUser custom input

1 participant