feat(cli): support @-mentioning files in AskUser custom input#26465
feat(cli): support @-mentioning files in AskUser custom input#26465
Conversation
|
Size Change: +3.05 kB (+0.01%) Total Size: 34 MB
ℹ️ View Unchanged
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the CLI user experience by enabling file referencing through Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces the AutocompleteTextInput component to provide file-path suggestions in the CLI's dialog views, replacing the standard TextInput in AskUserDialog. The feedback highlights that the package-lock.json contains numerous unintended dependency changes that should be reverted. Additionally, the AutocompleteTextInput component uses an unsafe type assertion for CommandContext which could lead to runtime errors, and the suggestion display mode should be dynamically adjusted based on its position (above vs. below) to ensure a correct user experience.
Summary
Enable users to reference specific files using
@mentioning within theAskUserDialog's text inputs (both for text-type questions and the custom "Other" option in choice questions).Details
AutocompleteTextInputcomponent that wrapsTextInputand provides@completion capabilities.useCommandCompletionandSuggestionsDisplayto provide the same file-search experience available in the main prompt.AskUserDialog.tsxto useAutocompleteTextInputinstead of the standardTextInput.eslintsuppression for a mockCommandContextrequired by the completion hook.Related Issues
Fixes #18495
How to Validate
AskUserwith a text input (e.g., providing feedback on a plan).@followed by a partial path.TaborEnterto select a file.Pre-Merge Checklist