fix(patch): cherry-pick 7cc19c2 to release/v0.41.0-preview.2-pr-26507 to patch version v0.41.0-preview.2 and create version 0.41.0-preview.3

[gemini-cli-robot]

This PR automatically cherry-picks commit 7cc19c2 to patch version v0.41.0-preview.2 in the preview release to create version 0.41.0-preview.3.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a UI rendering issue in the SettingsDialog component where the bottom border was not correctly positioned or displayed when the terminal height was limited. By switching from a fixed height to a dynamic maximum height, the component now adapts properly to constrained environments, ensuring a consistent visual experience.

Highlights

• UI Layout Fix: Updated the BaseSettingsDialog component to use maxHeight instead of a fixed height, ensuring the bottom border renders correctly when terminal height is constrained.
• Test Coverage: Added a new test case to verify that the SettingsDialog maintains its bottom border and layout integrity under constrained terminal height conditions.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request ensures the SettingsDialog renders its bottom border correctly when the terminal height is constrained. It includes a new test case with associated SVG and text snapshots to verify this behavior. A review comment identifies a potential layout regression in BaseSettingsDialog.tsx where replacing height="100%" with maxHeight={availableHeight} could cause issues if availableHeight is undefined; a fallback to "100%" and a descriptive comment were suggested to ensure stability and follow repository guidelines.

[gemini-code-assist]

The change from height="100%" to maxHeight={availableHeight} introduces a layout regression when availableHeight is undefined (the default state). In this case, the Box loses its height constraint, which can cause the dialog to overflow the terminal window. You should provide a fallback to "100%". Additionally, per repository rules, please add a detailed comment explaining how this height is derived to prevent incorrect refactoring in the future.

Suggested change

	maxHeight={availableHeight}
	maxHeight={availableHeight ?? '100%'} // Fallback to 100% to prevent overflow when availableHeight is undefined

References

1. For complex layout calculations that depend on component rendering logic (like conditional borders or padding), add detailed comments explaining how the height is derived to prevent incorrect refactoring.