Skip to content

fix(patch): cherry-pick 3627f47 to release/v0.42.0-preview.0-pr-26542 to patch version v0.42.0-preview.0 and create version 0.42.0-preview.1#26544

Merged
galz10 merged 1 commit intorelease/v0.42.0-preview.0-pr-26542from
hotfix/v0.42.0-preview.0/0.42.0-preview.1/preview/cherry-pick-3627f47/pr-26542
May 5, 2026
Merged

fix(patch): cherry-pick 3627f47 to release/v0.42.0-preview.0-pr-26542 to patch version v0.42.0-preview.0 and create version 0.42.0-preview.1#26544
galz10 merged 1 commit intorelease/v0.42.0-preview.0-pr-26542from
hotfix/v0.42.0-preview.0/0.42.0-preview.1/preview/cherry-pick-3627f47/pr-26542

Conversation

@gemini-cli-robot
Copy link
Copy Markdown
Collaborator

This PR automatically cherry-picks commit 3627f47 to patch version v0.42.0-preview.0 in the preview release to create version 0.42.0-preview.1.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the policy engine to ensure consistent behavior for redirected commands in automated approval modes. By removing the dependency on sandbox status for these specific modes, the engine now correctly maintains the intended trust level for agent actions, preventing unnecessary user prompts.

Highlights

  • Policy Engine Logic Update: Modified the policy engine to prevent downgrading to ASK_USER for redirected commands when in AUTO_EDIT or YOLO modes, regardless of whether sandboxing is enabled.
  • Regression Testing: Added a new test case to verify that redirected shell commands remain in ALLOW status when running in YOLO mode without a sandbox.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@galz10 galz10 enabled auto-merge (squash) May 5, 2026 21:42
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Size Change: -105 B (0%)

Total Size: 34 MB

Filename Size Change
./bundle/chunk-7KVR4SUI.js 0 B -19.5 kB (removed) 🏆
./bundle/chunk-DMHPWISC.js 0 B -49.2 kB (removed) 🏆
./bundle/chunk-E6MXDTKP.js 0 B -3.8 kB (removed) 🏆
./bundle/chunk-FVG2IZDH.js 0 B -12.5 kB (removed) 🏆
./bundle/chunk-RC2FTYTA.js 0 B -14.7 MB (removed) 🏆
./bundle/chunk-THKODI2D.js 0 B -658 kB (removed) 🏆
./bundle/chunk-UACLT43L.js 0 B -3.43 kB (removed) 🏆
./bundle/chunk-VDYBTRU2.js 0 B -2.78 MB (removed) 🏆
./bundle/core-4OQT6ZP6.js 0 B -48.7 kB (removed) 🏆
./bundle/devtoolsService-ST2UQROS.js 0 B -28 kB (removed) 🏆
./bundle/gemini-QB2LY7B3.js 0 B -583 kB (removed) 🏆
./bundle/interactiveCli-TPYQO2BP.js 0 B -1.29 MB (removed) 🏆
./bundle/liteRtServerManager-UGECWWOK.js 0 B -2.11 kB (removed) 🏆
./bundle/oauth2-provider-4Y5QQHSB.js 0 B -9.16 kB (removed) 🏆
./bundle/chunk-EDH5IPHV.js 19.5 kB +19.5 kB (new file) 🆕
./bundle/chunk-GNA2RN2M.js 658 kB +658 kB (new file) 🆕
./bundle/chunk-L53H6EIQ.js 12.5 kB +12.5 kB (new file) 🆕
./bundle/chunk-N6JOTQMJ.js 49.2 kB +49.2 kB (new file) 🆕
./bundle/chunk-PUSLD2JN.js 3.43 kB +3.43 kB (new file) 🆕
./bundle/chunk-QZ53N5WX.js 14.7 MB +14.7 MB (new file) 🆕
./bundle/chunk-YHBKYBHD.js 3.8 kB +3.8 kB (new file) 🆕
./bundle/chunk-YVZLGNUB.js 2.78 MB +2.78 MB (new file) 🆕
./bundle/core-4KT567ME.js 48.7 kB +48.7 kB (new file) 🆕
./bundle/devtoolsService-BTO72YOO.js 28 kB +28 kB (new file) 🆕
./bundle/gemini-QVVSXBVW.js 583 kB +583 kB (new file) 🆕
./bundle/interactiveCli-3GIF5VNA.js 1.29 MB +1.29 MB (new file) 🆕
./bundle/liteRtServerManager-E2C3BX4Q.js 2.11 kB +2.11 kB (new file) 🆕
./bundle/oauth2-provider-Z2UL5NBJ.js 9.16 kB +9.16 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./bundle/bundled/third_party/index.js 8 MB 0 B
./bundle/chunk-34MYV7JD.js 2.45 kB 0 B
./bundle/chunk-5AUYMPVF.js 858 B 0 B
./bundle/chunk-5PS3AYFU.js 1.18 kB 0 B
./bundle/chunk-664ZODQF.js 124 kB 0 B
./bundle/chunk-DAHVX5MI.js 206 kB 0 B
./bundle/chunk-ECNYAST2.js 1.97 MB 0 B
./bundle/chunk-IUUIT4SU.js 56.5 kB 0 B
./bundle/chunk-RJTRUG2J.js 39.8 kB 0 B
./bundle/cleanup-BFCE5UFO.js 0 B -932 B (removed) 🏆
./bundle/devtools-36NN55EP.js 696 kB 0 B
./bundle/dist-T73EYRDX.js 356 B 0 B
./bundle/events-XB7DADIJ.js 418 B 0 B
./bundle/examples/hooks/scripts/on-start.js 188 B 0 B
./bundle/examples/mcp-server/example.js 1.43 kB 0 B
./bundle/gemini.js 5.1 kB 0 B
./bundle/getMachineId-bsd-TXG52NKR.js 1.55 kB 0 B
./bundle/getMachineId-darwin-7OE4DDZ6.js 1.55 kB 0 B
./bundle/getMachineId-linux-SHIFKOOX.js 1.34 kB 0 B
./bundle/getMachineId-unsupported-5U5DOEYY.js 1.06 kB 0 B
./bundle/getMachineId-win-6KLLGOI4.js 1.72 kB 0 B
./bundle/memoryDiscovery-FB7MMKTA.js 980 B 0 B
./bundle/multipart-parser-KPBZEGQU.js 11.7 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 222 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 229 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 13.4 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B
./bundle/src-QVCVGIUX.js 47 kB 0 B
./bundle/start-7NZL7JJ3.js 0 B -652 B (removed) 🏆
./bundle/tree-sitter-7U6MW5PS.js 274 kB 0 B
./bundle/tree-sitter-bash-34ZGLXVX.js 1.84 MB 0 B
./bundle/cleanup-VSVIMSPZ.js 932 B +932 B (new file) 🆕
./bundle/start-KVYWPCPG.js 652 B +652 B (new file) 🆕

compressed-size-action

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the policy engine to allow shell redirections without user confirmation in both AUTO_EDIT and YOLO modes, even when a sandbox is not enabled, and adds a test case to verify this behavior in YOLO mode. Feedback identifies a security concern where AUTO_EDIT mode should still be restricted to sandbox environments to prevent unintended host file system access, whereas YOLO mode is intentionally designed to bypass such restrictions.

Comment on lines 293 to 296
if (
sandboxEnabled &&
(this.approvalMode === ApprovalMode.AUTO_EDIT ||
this.approvalMode === ApprovalMode.YOLO)
this.approvalMode === ApprovalMode.AUTO_EDIT ||
this.approvalMode === ApprovalMode.YOLO
) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-high high

The removal of the sandboxEnabled check in shouldDowngradeForRedirection allows shell redirections (e.g., >, >>, <) to be executed on the host system without user confirmation when in AUTO_EDIT mode. While YOLO mode intentionally allows this behavior even without a sandbox per project policy, AUTO_EDIT mode should still be restricted to sandbox environments for these operations to prevent unintended host file system access.

Suggested change
if (
sandboxEnabled &&
(this.approvalMode === ApprovalMode.AUTO_EDIT ||
this.approvalMode === ApprovalMode.YOLO)
this.approvalMode === ApprovalMode.AUTO_EDIT ||
this.approvalMode === ApprovalMode.YOLO
) {
if (
(this.approvalMode === ApprovalMode.AUTO_EDIT && !(this.sandboxManager instanceof NoopSandboxManager)) ||
this.approvalMode === ApprovalMode.YOLO
) {
References
  1. In YOLO mode, dangerous commands are intentionally allowed to proceed with an 'ALLOW' decision, even when no sandbox is active.

@galz10 galz10 merged commit 246f984 into release/v0.42.0-preview.0-pr-26542 May 5, 2026
26 checks passed
@galz10 galz10 deleted the hotfix/v0.42.0-preview.0/0.42.0-preview.1/preview/cherry-pick-3627f47/pr-26542 branch May 5, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants