Conversation
|
Size Change: +140 B (0%) Total Size: 34 MB
ℹ️ View Unchanged
|
e08f2b7 to
30c64d5
Compare
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request optimizes shell argument escaping by introducing a regex-based check to avoid wrapping simple, safe strings in quotes. This improves command readability and compatibility in Windows environments (cmd.exe and PowerShell) by ensuring that identifiers like UUIDs are passed as raw strings when they do not contain special characters. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request modifies the escapeShellArg utility to avoid unnecessary quoting of simple alphanumeric strings, such as UUIDs, when targeting PowerShell and CMD environments. The changes include updated logic in packages/core using a regex check for safe characters and corresponding updates to unit and component tests to ensure correct behavior. I have no feedback to provide as there were no review comments to evaluate.
Summary
Don't wrap args unnecessarily.
Related Issues
Fixes: #23718
How to Validate
Run on windows in cmd.exe and verify that the
To resume this sessionmessage doesn't quote the session id.