Skip to content

don't wrap args unnecessarily#26599

Merged
scidomino merged 1 commit intomainfrom
tomm_quotes
May 6, 2026
Merged

don't wrap args unnecessarily#26599
scidomino merged 1 commit intomainfrom
tomm_quotes

Conversation

@scidomino
Copy link
Copy Markdown
Collaborator

@scidomino scidomino commented May 6, 2026

Summary

Don't wrap args unnecessarily.

Related Issues

Fixes: #23718

How to Validate

Run on windows in cmd.exe and verify that the To resume this session message doesn't quote the session id.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

Size Change: +140 B (0%)

Total Size: 34 MB

Filename Size Change
./bundle/chunk-2IBEJPNO.js 0 B -14.8 MB (removed) 🏆
./bundle/chunk-AXLYMNYK.js 0 B -12.5 kB (removed) 🏆
./bundle/chunk-BI6KULUF.js 0 B -19.5 kB (removed) 🏆
./bundle/chunk-JKSQPMOD.js 0 B -658 kB (removed) 🏆
./bundle/chunk-JP5KO3I7.js 0 B -49.2 kB (removed) 🏆
./bundle/chunk-QOQEXDKP.js 0 B -3.43 kB (removed) 🏆
./bundle/chunk-QQFKM5HQ.js 0 B -2.78 MB (removed) 🏆
./bundle/chunk-YI3C2JLK.js 0 B -3.8 kB (removed) 🏆
./bundle/core-CDH524SZ.js 0 B -48.8 kB (removed) 🏆
./bundle/devtoolsService-U6BLMBHR.js 0 B -28 kB (removed) 🏆
./bundle/gemini-GMEIRNTM.js 0 B -584 kB (removed) 🏆
./bundle/interactiveCli-3FVMXRW7.js 0 B -1.29 MB (removed) 🏆
./bundle/liteRtServerManager-556V6VHM.js 0 B -2.11 kB (removed) 🏆
./bundle/oauth2-provider-MZ6GKSWU.js 0 B -9.16 kB (removed) 🏆
./bundle/chunk-4RGYF5DT.js 3.43 kB +3.43 kB (new file) 🆕
./bundle/chunk-6DCCIEQW.js 3.8 kB +3.8 kB (new file) 🆕
./bundle/chunk-GL2TEDCR.js 658 kB +658 kB (new file) 🆕
./bundle/chunk-N2TX2AVN.js 14.8 MB +14.8 MB (new file) 🆕
./bundle/chunk-WOXCTKKF.js 12.5 kB +12.5 kB (new file) 🆕
./bundle/chunk-XLET7QH6.js 2.78 MB +2.78 MB (new file) 🆕
./bundle/chunk-XLP5JBW5.js 19.5 kB +19.5 kB (new file) 🆕
./bundle/chunk-ZGQP73JH.js 49.2 kB +49.2 kB (new file) 🆕
./bundle/core-E2ODFB5N.js 48.8 kB +48.8 kB (new file) 🆕
./bundle/devtoolsService-DZURNYZF.js 28 kB +28 kB (new file) 🆕
./bundle/gemini-2ECOAIC2.js 584 kB +584 kB (new file) 🆕
./bundle/interactiveCli-P4HVXKWV.js 1.29 MB +1.29 MB (new file) 🆕
./bundle/liteRtServerManager-TIAYFGYD.js 2.11 kB +2.11 kB (new file) 🆕
./bundle/oauth2-provider-PORVNQUR.js 9.16 kB +9.16 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./bundle/bundled/third_party/index.js 8 MB 0 B
./bundle/chunk-34MYV7JD.js 2.45 kB 0 B
./bundle/chunk-5AUYMPVF.js 858 B 0 B
./bundle/chunk-5PS3AYFU.js 1.18 kB 0 B
./bundle/chunk-664ZODQF.js 124 kB 0 B
./bundle/chunk-DAHVX5MI.js 206 kB 0 B
./bundle/chunk-IUUIT4SU.js 56.5 kB 0 B
./bundle/chunk-RJTRUG2J.js 39.8 kB 0 B
./bundle/chunk-VJSUVOZ4.js 1.97 MB 0 B
./bundle/cleanup-YJTT6PFQ.js 0 B -932 B (removed) 🏆
./bundle/devtools-36NN55EP.js 696 kB 0 B
./bundle/dist-T73EYRDX.js 356 B 0 B
./bundle/events-XB7DADIJ.js 418 B 0 B
./bundle/examples/hooks/scripts/on-start.js 188 B 0 B
./bundle/examples/mcp-server/example.js 1.43 kB 0 B
./bundle/gemini.js 5.1 kB 0 B
./bundle/getMachineId-bsd-TXG52NKR.js 1.55 kB 0 B
./bundle/getMachineId-darwin-7OE4DDZ6.js 1.55 kB 0 B
./bundle/getMachineId-linux-SHIFKOOX.js 1.34 kB 0 B
./bundle/getMachineId-unsupported-5U5DOEYY.js 1.06 kB 0 B
./bundle/getMachineId-win-6KLLGOI4.js 1.72 kB 0 B
./bundle/memoryDiscovery-NGHTMHWQ.js 980 B 0 B
./bundle/multipart-parser-KPBZEGQU.js 11.7 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 222 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 229 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 13.4 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B
./bundle/src-QVCVGIUX.js 47 kB 0 B
./bundle/start-ILUA24M2.js 0 B -652 B (removed) 🏆
./bundle/tree-sitter-7U6MW5PS.js 274 kB 0 B
./bundle/tree-sitter-bash-34ZGLXVX.js 1.84 MB 0 B
./bundle/cleanup-5WK3OMVZ.js 932 B +932 B (new file) 🆕
./bundle/start-5TG3DVIF.js 652 B +652 B (new file) 🆕

compressed-size-action

@scidomino scidomino force-pushed the tomm_quotes branch 2 times, most recently from e08f2b7 to 30c64d5 Compare May 6, 2026 18:45
@gemini-cli gemini-cli Bot added the area/core Issues related to User Interface, OS Support, Core Functionality label May 6, 2026
@scidomino scidomino marked this pull request as ready for review May 6, 2026 20:44
@scidomino scidomino requested a review from a team as a code owner May 6, 2026 20:44
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request optimizes shell argument escaping by introducing a regex-based check to avoid wrapping simple, safe strings in quotes. This improves command readability and compatibility in Windows environments (cmd.exe and PowerShell) by ensuring that identifiers like UUIDs are passed as raw strings when they do not contain special characters.

Highlights

  • Conditional Quoting Logic: Updated escapeShellArg to skip unnecessary quoting for simple alphanumeric strings (including hyphens, underscores, and dots) in both PowerShell and cmd.exe environments.
  • Test Suite Updates: Adjusted unit tests in SessionSummaryDisplay.test.tsx and shell-utils.test.ts to reflect the new non-quoted output for simple arguments.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the escapeShellArg utility to avoid unnecessary quoting of simple alphanumeric strings, such as UUIDs, when targeting PowerShell and CMD environments. The changes include updated logic in packages/core using a regex check for safe characters and corresponding updates to unit and component tests to ensure correct behavior. I have no feedback to provide as there were no review comments to evaluate.

@mattKorwel mattKorwel added this pull request to the merge queue May 6, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 6, 2026
@scidomino scidomino added this pull request to the merge queue May 6, 2026
Merged via the queue into main with commit a809bc7 May 6, 2026
27 checks passed
@scidomino scidomino deleted the tomm_quotes branch May 6, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quotes should be removed from "To resume this session" reminder

3 participants