fix(skills): support single-line YAML descriptions in SKILL.md frontm…#26765
fix(skills): support single-line YAML descriptions in SKILL.md frontm…#26765anishs1207 wants to merge 2 commits into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the reliability of the skill loader by refining how frontmatter is parsed from SKILL.md files. It addresses issues with special characters and formatting, ensuring that skill metadata is correctly extracted even when descriptions contain quotes or files include non-standard headers like BOMs. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request enhances the skill loader's robustness by updating the frontmatter regex to support leading whitespace and Byte Order Marks (BOM). Additionally, the simple frontmatter parser now correctly strips outer single or double quotes from the 'name' and 'description' fields. New test cases have been added to verify these changes, including handling of BOM and long descriptions. I have no feedback to provide as there were no review comments.
Summary
This PR enables support for single line YAML descriptions inside the SKILL.md files at (
packages/core/src/skills/skillLoader.ts). Also added test coverage (packages/core/src/skills/skillLoader.test.ts)Related Issues
It fixes #25693
How to Validate
Verify that both skills appear in the discovered skills list:
Pre-Merge Checklist
fix2.mp4