fix(ui): added a gutter width to the input prompt width calculation#26882
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a UI rendering issue where text at the edge of the input prompt was being clipped. By accounting for a scrollbar gutter width in the component's width calculation, the UI now correctly accommodates content, ensuring full visibility of the input text. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses a rendering issue where the last character of a visual line could be clipped when its width matched the input width. It introduces a SCROLLBAR_GUTTER_WIDTH constant and applies it to the input width in the InputPrompt component. Additionally, a new test case has been added to InputPrompt.test.tsx to ensure correct terminal buffer rendering, and relevant snapshots have been updated. I have no feedback to provide.
|
Size Change: +53 B (0%) Total Size: 34.1 MB
ℹ️ View Unchanged
|
Summary
Added a gutter width to the input prompt width calculation
Details
Related Issues
Fixes #26212
How to Validate
Write a text that is entirely the input prompt's width and make sure it is properly rendered.
Pre-Merge Checklist