Skip to content

fix(ui): added a gutter width to the input prompt width calculation#26882

Merged
devr0306 merged 1 commit into
mainfrom
input-prompt-width
May 11, 2026
Merged

fix(ui): added a gutter width to the input prompt width calculation#26882
devr0306 merged 1 commit into
mainfrom
input-prompt-width

Conversation

@devr0306
Copy link
Copy Markdown
Contributor

Summary

Added a gutter width to the input prompt width calculation

Details

Related Issues

Fixes #26212

How to Validate

Write a text that is entirely the input prompt's width and make sure it is properly rendered.

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@devr0306 devr0306 requested a review from a team as a code owner May 11, 2026 19:01
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a UI rendering issue where text at the edge of the input prompt was being clipped. By accounting for a scrollbar gutter width in the component's width calculation, the UI now correctly accommodates content, ensuring full visibility of the input text.

Highlights

  • UI Layout Adjustment: Introduced a SCROLLBAR_GUTTER_WIDTH constant and incorporated it into the InputPrompt width calculation to prevent character clipping.
  • Testing: Added a new test case in InputPrompt.test.tsx to verify that visual lines matching the input width are rendered correctly without clipping.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a rendering issue where the last character of a visual line could be clipped when its width matched the input width. It introduces a SCROLLBAR_GUTTER_WIDTH constant and applies it to the input width in the InputPrompt component. Additionally, a new test case has been added to InputPrompt.test.tsx to ensure correct terminal buffer rendering, and relevant snapshots have been updated. I have no feedback to provide.

@github-actions
Copy link
Copy Markdown

Size Change: +53 B (0%)

Total Size: 34.1 MB

Filename Size Change
./bundle/chunk-2SHHGVFB.js 0 B -3.8 kB (removed) 🏆
./bundle/chunk-D7JGORYI.js 0 B -14.8 MB (removed) 🏆
./bundle/chunk-KH5OVD77.js 0 B -12.5 kB (removed) 🏆
./bundle/chunk-UUFWUC6O.js 0 B -19.5 kB (removed) 🏆
./bundle/chunk-VET2ZS2T.js 0 B -49.2 kB (removed) 🏆
./bundle/chunk-VT4LYCCA.js 0 B -658 kB (removed) 🏆
./bundle/chunk-WE5GHUGE.js 0 B -2.78 MB (removed) 🏆
./bundle/chunk-YQOXTP67.js 0 B -3.43 kB (removed) 🏆
./bundle/core-LNG6B7ZV.js 0 B -49.2 kB (removed) 🏆
./bundle/devtoolsService-K3EBAKYX.js 0 B -28 kB (removed) 🏆
./bundle/gemini-KSFBP4PS.js 0 B -587 kB (removed) 🏆
./bundle/interactiveCli-LA2ENL5N.js 0 B -1.3 MB (removed) 🏆
./bundle/liteRtServerManager-AT6EGVMF.js 0 B -2.11 kB (removed) 🏆
./bundle/oauth2-provider-XOGKOBVZ.js 0 B -9.16 kB (removed) 🏆
./bundle/chunk-2P54LFOG.js 12.5 kB +12.5 kB (new file) 🆕
./bundle/chunk-4WI6R6OM.js 19.5 kB +19.5 kB (new file) 🆕
./bundle/chunk-DGX2G5PF.js 14.8 MB +14.8 MB (new file) 🆕
./bundle/chunk-IBC6OWJD.js 2.78 MB +2.78 MB (new file) 🆕
./bundle/chunk-JRJV7TPF.js 3.43 kB +3.43 kB (new file) 🆕
./bundle/chunk-LBB6JKKA.js 3.8 kB +3.8 kB (new file) 🆕
./bundle/chunk-UYTXOQSQ.js 658 kB +658 kB (new file) 🆕
./bundle/chunk-VLHXV7CA.js 49.2 kB +49.2 kB (new file) 🆕
./bundle/core-ADLTNMKX.js 49.2 kB +49.2 kB (new file) 🆕
./bundle/devtoolsService-5EFWNTBT.js 28 kB +28 kB (new file) 🆕
./bundle/gemini-M3PRTBEN.js 587 kB +587 kB (new file) 🆕
./bundle/interactiveCli-44KDH4MR.js 1.3 MB +1.3 MB (new file) 🆕
./bundle/liteRtServerManager-KE2OUVK5.js 2.11 kB +2.11 kB (new file) 🆕
./bundle/oauth2-provider-EZMCEM57.js 9.16 kB +9.16 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./bundle/bundled/third_party/index.js 8 MB 0 B
./bundle/chunk-34MYV7JD.js 2.45 kB 0 B
./bundle/chunk-5AUYMPVF.js 858 B 0 B
./bundle/chunk-5PS3AYFU.js 1.18 kB 0 B
./bundle/chunk-664ZODQF.js 124 kB 0 B
./bundle/chunk-6NNHMYAM.js 1.97 MB 0 B
./bundle/chunk-DAHVX5MI.js 206 kB 0 B
./bundle/chunk-IUUIT4SU.js 56.5 kB 0 B
./bundle/chunk-RJTRUG2J.js 39.8 kB 0 B
./bundle/cleanup-YTRUL7OD.js 0 B -932 B (removed) 🏆
./bundle/devtools-36NN55EP.js 696 kB 0 B
./bundle/dist-T73EYRDX.js 356 B 0 B
./bundle/events-XB7DADIJ.js 418 B 0 B
./bundle/examples/hooks/scripts/on-start.js 188 B 0 B
./bundle/examples/mcp-server/example.js 1.43 kB 0 B
./bundle/gemini.js 5.1 kB 0 B
./bundle/getMachineId-bsd-TXG52NKR.js 1.55 kB 0 B
./bundle/getMachineId-darwin-7OE4DDZ6.js 1.55 kB 0 B
./bundle/getMachineId-linux-SHIFKOOX.js 1.34 kB 0 B
./bundle/getMachineId-unsupported-5U5DOEYY.js 1.06 kB 0 B
./bundle/getMachineId-win-6KLLGOI4.js 1.72 kB 0 B
./bundle/memoryDiscovery-QGLPGQCK.js 980 B 0 B
./bundle/multipart-parser-KPBZEGQU.js 11.7 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 222 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 229 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 13.4 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B
./bundle/src-QVCVGIUX.js 47 kB 0 B
./bundle/start-VKKTE6BQ.js 0 B -652 B (removed) 🏆
./bundle/tree-sitter-7U6MW5PS.js 274 kB 0 B
./bundle/tree-sitter-bash-34ZGLXVX.js 1.84 MB 0 B
./bundle/cleanup-ZE7ZZEAX.js 932 B +932 B (new file) 🆕
./bundle/start-YFZY7ZD7.js 652 B +652 B (new file) 🆕

compressed-size-action

@gemini-cli gemini-cli Bot added priority/p2 Important but can be addressed in a future release. area/core Issues related to User Interface, OS Support, Core Functionality labels May 11, 2026
@devr0306 devr0306 added this pull request to the merge queue May 11, 2026
Merged via the queue into main with commit c0d5ab1 May 11, 2026
28 checks passed
@devr0306 devr0306 deleted the input-prompt-width branch May 11, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality priority/p2 Important but can be addressed in a future release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: input prompt clips the last character of a line whose width exactly matches the prompt width

2 participants