Skip to content

fix(cli): read bootstrap settings from custom home#27425

Open
officialasishkumar wants to merge 1 commit into
google-gemini:mainfrom
officialasishkumar:fix/relaunch-home-settings-path
Open

fix(cli): read bootstrap settings from custom home#27425
officialasishkumar wants to merge 1 commit into
google-gemini:mainfrom
officialasishkumar:fix/relaunch-home-settings-path

Conversation

@officialasishkumar
Copy link
Copy Markdown

Summary

Fix the lightweight CLI bootstrap so it reads global user settings from the same path as the normal storage layer when GEMINI_CLI_HOME is set.

Details

The bootstrap process reads advanced.autoConfigureMemory before loading the full settings system. It previously treated GEMINI_CLI_HOME as the .gemini directory itself, so $GEMINI_CLI_HOME/.gemini/settings.json was ignored during initial memory configuration.

This adds a small bootstrap settings-path helper that mirrors Storage.getGlobalSettingsPath() without importing core, then uses it from packages/cli/index.ts. The new unit test covers both the default home path and the custom GEMINI_CLI_HOME path.

Related Issues

Fixes #27421

How to Validate

  • ./node_modules/.bin/prettier --check packages/cli/index.ts packages/cli/src/utils/bootstrapSettings.ts packages/cli/src/utils/bootstrapSettings.test.ts
  • ./node_modules/.bin/eslint packages/cli/index.ts packages/cli/src/utils/bootstrapSettings.ts packages/cli/src/utils/bootstrapSettings.test.ts --max-warnings 0
  • timeout 180s ./node_modules/.bin/tsc -p packages/cli/tsconfig.json --noEmit --pretty false
  • From packages/cli: timeout 180s ../../node_modules/.bin/vitest run src/utils/bootstrapSettings.test.ts --coverage.enabled=false --pool=threads
  • Manually checked getBootstrapSettingsPath() resolves GEMINI_CLI_HOME=/tmp/custom-gemini-home to /tmp/custom-gemini-home/.gemini/settings.json.

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

The lightweight parent process reads advanced.autoConfigureMemory before the full settings loader is available. It previously treated GEMINI_CLI_HOME as the .gemini directory itself, so settings at the normal custom-home path were ignored.

Add a small bootstrap settings-path helper that mirrors Storage.getGlobalSettingsPath without importing core, and cover the default-home and custom-home cases.

Fixes google-gemini#27421
@officialasishkumar officialasishkumar requested a review from a team as a code owner May 25, 2026 03:09
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the CLI bootstrap process to ensure consistent resolution of global user settings. By extracting the path resolution logic into a dedicated utility, the CLI now correctly handles custom home directory configurations, preventing settings from being ignored during initial memory configuration.

Highlights

  • Centralized Settings Path Resolution: Introduced a new helper function getBootstrapSettingsPath to standardize how the CLI locates the global settings file during the bootstrap process.
  • Fix for Custom Home Directory: Corrected the logic for resolving GEMINI_CLI_HOME so that it correctly appends the .gemini directory, ensuring custom home configurations are properly respected.
  • Improved Test Coverage: Added comprehensive unit tests to verify path resolution for both default and custom home directory scenarios.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new utility function getBootstrapSettingsPath in packages/cli/src/utils/bootstrapSettings.ts to centralize the resolution of the global settings path. It refactors packages/cli/index.ts to use this utility, ensuring consistent path resolution for the bootstrap process. Additionally, a corresponding test file packages/cli/src/utils/bootstrapSettings.test.ts has been added to verify the logic under different environment configurations. I have no feedback to provide.

@gemini-cli gemini-cli Bot added priority/p2 Important but can be addressed in a future release. area/core Issues related to User Interface, OS Support, Core Functionality labels May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality priority/p2 Important but can be addressed in a future release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

advanced.autoConfigureMemory ignores settings when GEMINI_CLI_HOME is set

1 participant