Skip to content

fix(patch): cherry-pick bd53951 to release/v0.45.0-preview.0-pr-27496 to patch version v0.45.0-preview.0 and create version 0.45.0-preview.1#27535

Merged
scidomino merged 1 commit into
release/v0.45.0-preview.0-pr-27496from
hotfix/v0.45.0-preview.0/0.45.0-preview.1/preview/cherry-pick-bd53951/pr-27496
May 28, 2026
Merged

fix(patch): cherry-pick bd53951 to release/v0.45.0-preview.0-pr-27496 to patch version v0.45.0-preview.0 and create version 0.45.0-preview.1#27535
scidomino merged 1 commit into
release/v0.45.0-preview.0-pr-27496from
hotfix/v0.45.0-preview.0/0.45.0-preview.1/preview/cherry-pick-bd53951/pr-27496

Conversation

@gemini-cli-robot
Copy link
Copy Markdown
Collaborator

This PR automatically cherry-picks commit bd53951 to patch version v0.45.0-preview.0 in the preview release to create version 0.45.0-preview.1.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request cherry-picks a fix to improve the stability of PTY resizing operations. It introduces a pre-check using process.kill(pid, 0) on non-Windows platforms to verify process existence before resizing, and refines the logic for catching and ignoring expected race-condition errors during PTY termination.

Highlights

  • Robust PTY Resize Handling: Improved error handling for PTY resizing by explicitly checking process status before attempting resize operations on non-Windows platforms.
  • Error Detection Improvements: Enhanced exception handling in the CLI and ShellExecutionService to better identify and ignore expected PTY exit errors.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Copy Markdown

Size Change: +235 B (0%)

Total Size: 33.9 MB

Filename Size Change
./bundle/chunk-273AZRBA.js 0 B -19.5 kB (removed) 🏆
./bundle/chunk-C3PZEEXA.js 0 B -13 kB (removed) 🏆
./bundle/chunk-FAQ4DU3Z.js 0 B -16.4 MB (removed) 🏆
./bundle/chunk-NQAGK56P.js 0 B -3.43 kB (removed) 🏆
./bundle/chunk-VTJLYUTT.js 0 B -661 kB (removed) 🏆
./bundle/chunk-WUM32UO5.js 0 B -2.79 MB (removed) 🏆
./bundle/chunk-YQFLIPBJ.js 0 B -3.77 kB (removed) 🏆
./bundle/chunk-ZMHIKBOH.js 0 B -49.2 kB (removed) 🏆
./bundle/core-MD6PIIZN.js 0 B -49.5 kB (removed) 🏆
./bundle/devtoolsService-RDFARP63.js 0 B -28 kB (removed) 🏆
./bundle/gemini-ESYVK4HM.js 0 B -589 kB (removed) 🏆
./bundle/interactiveCli-AKSULILS.js 0 B -1.3 MB (removed) 🏆
./bundle/liteRtServerManager-TZCXPIZF.js 0 B -2.08 kB (removed) 🏆
./bundle/oauth2-provider-Q36IJNM5.js 0 B -9.12 kB (removed) 🏆
./bundle/chunk-33M4KD2W.js 3.43 kB +3.43 kB (new file) 🆕
./bundle/chunk-56IE4M7U.js 661 kB +661 kB (new file) 🆕
./bundle/chunk-7MEBMJ6Z.js 2.79 MB +2.79 MB (new file) 🆕
./bundle/chunk-BHJZJ2BR.js 49.2 kB +49.2 kB (new file) 🆕
./bundle/chunk-L4HBBMOU.js 19.5 kB +19.5 kB (new file) 🆕
./bundle/chunk-LCPVJZZI.js 3.77 kB +3.77 kB (new file) 🆕
./bundle/chunk-XFIVQV3Z.js 13 kB +13 kB (new file) 🆕
./bundle/chunk-ZXUASYKO.js 16.4 MB +16.4 MB (new file) 🆕
./bundle/core-BCK4NI7C.js 49.5 kB +49.5 kB (new file) 🆕
./bundle/devtoolsService-LJ3PEA6B.js 28 kB +28 kB (new file) 🆕
./bundle/gemini-KFFKWFCC.js 589 kB +589 kB (new file) 🆕
./bundle/interactiveCli-RHVTYKJG.js 1.3 MB +1.3 MB (new file) 🆕
./bundle/liteRtServerManager-K5HFZLJ3.js 2.08 kB +2.08 kB (new file) 🆕
./bundle/oauth2-provider-LN7WTY2N.js 9.12 kB +9.12 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./bundle/bundled/third_party/index.js 8 MB 0 B
./bundle/chunk-34MYV7JD.js 2.45 kB 0 B
./bundle/chunk-5AUYMPVF.js 858 B 0 B
./bundle/chunk-5PS3AYFU.js 1.18 kB 0 B
./bundle/chunk-6HI7VNOG.js 124 kB 0 B
./bundle/chunk-DAHVX5MI.js 206 kB 0 B
./bundle/chunk-IUUIT4SU.js 56.5 kB 0 B
./bundle/chunk-TUDYL3X4.js 40.3 kB 0 B
./bundle/cleanup-FOS6ND7Q.js 0 B -902 B (removed) 🏆
./bundle/devtools-V7NE4CQA.js 696 kB 0 B
./bundle/events-XB7DADIJ.js 418 B 0 B
./bundle/examples/hooks/scripts/on-start.js 188 B 0 B
./bundle/examples/mcp-server/example.js 1.43 kB 0 B
./bundle/gemini.js 5.38 kB +55 B (+1.03%)
./bundle/getMachineId-bsd-TXG52NKR.js 1.55 kB 0 B
./bundle/getMachineId-darwin-7OE4DDZ6.js 1.55 kB 0 B
./bundle/getMachineId-linux-SHIFKOOX.js 1.34 kB 0 B
./bundle/getMachineId-unsupported-5U5DOEYY.js 1.06 kB 0 B
./bundle/getMachineId-win-6KLLGOI4.js 1.72 kB 0 B
./bundle/https-proxy-agent-AVGR4LHR.js 490 B 0 B
./bundle/multipart-parser-KPBZEGQU.js 11.7 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B
./bundle/src-LG4OHBW7.js 233 kB 0 B
./bundle/src-QVCVGIUX.js 47 kB 0 B
./bundle/start-XSIPXOFE.js 0 B -622 B (removed) 🏆
./bundle/tree-sitter-7U6MW5PS.js 274 kB 0 B
./bundle/tree-sitter-bash-34ZGLXVX.js 1.84 MB 0 B
./bundle/worker/worker-entry.js 361 kB 0 B
./bundle/cleanup-GJCC2M7Y.js 902 B +902 B (new file) 🆕
./bundle/start-ERDGJDSZ.js 622 B +622 B (new file) 🆕

compressed-size-action

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves error handling and stability during PTY resizing. In packages/cli/index.ts, uncaught exception handling is enhanced to safely check for EBADF error codes. In packages/core/src/services/shellExecutionService.ts, the ShellExecutionService now checks if the process is still alive using process.kill(pid, 0) on non-Windows platforms before attempting a resize, bailing early if the process has already exited (ESRCH). There are no review comments to evaluate, and I have no additional feedback to provide.

@scidomino scidomino enabled auto-merge (squash) May 28, 2026 16:38
@scidomino scidomino merged commit 5a0bee9 into release/v0.45.0-preview.0-pr-27496 May 28, 2026
26 checks passed
@scidomino scidomino deleted the hotfix/v0.45.0-preview.0/0.45.0-preview.1/preview/cherry-pick-bd53951/pr-27496 branch May 28, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants