fix(patch): cherry-pick bd53951 to release/v0.45.0-preview.0-pr-27496 to patch version v0.45.0-preview.0 and create version 0.45.0-preview.1#27535
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request cherry-picks a fix to improve the stability of PTY resizing operations. It introduces a pre-check using process.kill(pid, 0) on non-Windows platforms to verify process existence before resizing, and refines the logic for catching and ignoring expected race-condition errors during PTY termination. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Size Change: +235 B (0%) Total Size: 33.9 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Code Review
This pull request improves error handling and stability during PTY resizing. In packages/cli/index.ts, uncaught exception handling is enhanced to safely check for EBADF error codes. In packages/core/src/services/shellExecutionService.ts, the ShellExecutionService now checks if the process is still alive using process.kill(pid, 0) on non-Windows platforms before attempting a resize, bailing early if the process has already exited (ESRCH). There are no review comments to evaluate, and I have no additional feedback to provide.
5a0bee9
into
release/v0.45.0-preview.0-pr-27496
This PR automatically cherry-picks commit bd53951 to patch version v0.45.0-preview.0 in the preview release to create version 0.45.0-preview.1.