Skip to content

Conversation

@sethvargo
Copy link
Contributor

This should resolve issues where output is swallowed

This should resolve issues where output is swallowed
@sethvargo sethvargo requested a review from a team as a code owner February 4, 2022 00:07
@sethvargo sethvargo enabled auto-merge (squash) February 4, 2022 00:07
@sethvargo sethvargo merged commit 58b4f9f into main Feb 4, 2022
@sethvargo sethvargo deleted the sethvargo/up branch February 4, 2022 00:19
@internettrans
Copy link

fwiw this commit maybe broke things for my situation. I was using the main tag of this github action, and things were resolved once I pinned to google-github-actions/deploy-appengine@v0.6.0. However, it also could have been other factors, as it had been a few days between the failed deployments and the new deployments.

The broken behavior I was seeing is that somehow old code was ending up in the container registry, so it would say the deployment succeeded but no new code was running. I don't know if that's something that could even be caused by the upgrade to @google-github-actions/setup-cloud-sdk@0.4.0, but thought I'd share in case others come hunting here for help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants