feat: Replace Node.js telemetry with Docker #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerop
force-pushed
the
feat/docker-telemetry
branch
2 times, most recently
from
c1ce85c to
a82c2d4
Compare
This commit replaces the Node.js-based telemetry setup with a more streamlined Docker-based approach. Key changes: - The `scripts/telemetry.js` and `scripts/telemetry_utils.js` files have been removed. - The `action.yml` now uses a Docker container to run the OpenTelemetry collector. - A `collector-gcp.yaml.template` file has been added to provide a version-controlled configuration for the collector.
jerop
force-pushed
the
feat/docker-telemetry
branch
from
a82c2d4 to
89853f7
Compare
sethvargo
approved these changes
Jul 18, 2025
Contributor
sethvargo
left a comment
sethvargo
left a comment
There was a problem hiding this comment.
Love to see all the simplification!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces the Node.js-based telemetry setup with a more streamlined Docker-based approach.
scripts/telemetry.jsandscripts/telemetry_utils.jsfiles have been removed.action.ymlnow uses a Docker container to run the OpenTelemetry collector.collector-gcp.yaml.templatefile has been added to provide a configuration for the collector.Fixes #11
Fixes #14
Thanks to @sethvargo for pairing on this!