-
Notifications
You must be signed in to change notification settings - Fork 200
Add manifest for creating custom app #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📋 Review SummaryThis PR introduces a GitHub App manifest file to facilitate the creation of a custom GitHub App for using this action. While this is a positive step towards simplifying setup, the initial configuration requests overly broad permissions and contains placeholder values that need clarification. 🔍 General Feedback
🎯 Specific Feedback🟡 High
🟢 Medium
🔵 Low
✅ Highlights
|
jerop
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how will this manifest be used? please add docs
add manifest for custom app fix lint Apply suggestions from code review Co-authored-by: Jerop Kipruto <jerop@google.com> Signed-off-by: Xuejie(Alicia) Tang <tangxuejie96@163.com> add instruction
JeromeJu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
add manifest for custom app