Skip to content

Fix: Add workflow name to telemetry resource attributes#493

Merged
cocosheng-g merged 1 commit intomainfrom
fix/telemetry-workflow-name
Apr 1, 2026
Merged

Fix: Add workflow name to telemetry resource attributes#493
cocosheng-g merged 1 commit intomainfrom
fix/telemetry-workflow-name

Conversation

@cocosheng-g
Copy link
Copy Markdown
Collaborator

This PR adds the workflow name to the OpenTelemetry resource attributes in the collector configuration. This fixes the issue where GEMINI_CLI_WORKFLOW_NAME is null in metric events for customer-triggered runs. Closes #492

@gemini-cli
Copy link
Copy Markdown
Contributor

gemini-cli Bot commented Apr 1, 2026

🤖 Hi @cocosheng-g, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

Copy link
Copy Markdown
Contributor

@gemini-cli gemini-cli Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR correctly adds the workflow name to the OpenTelemetry resource attributes in the collector configuration. This ensures that telemetry events contain the workflow context, effectively fixing the issue where it was previously missing or null in customer-triggered runs.

🔍 General Feedback

  • The addition is well-integrated and consistent with existing resource attribute patterns in the configuration template.
  • Leveraging the sanitize_workflow_name step is a good practice, ensuring that the workflow name is safe for shell command expansion and formatted correctly for telemetry purposes.
  • The use of GH_WORKFLOW_NAME across multiple steps in action.yml remains consistent with the local conventions of this project.

@cocosheng-g cocosheng-g self-assigned this Apr 1, 2026
@cocosheng-g cocosheng-g merged commit 41f4f29 into main Apr 1, 2026
35 checks passed
@cocosheng-g cocosheng-g deleted the fix/telemetry-workflow-name branch April 1, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Telemetry: GEMINI_CLI_WORKFLOW_NAME is null in metric events

2 participants