Skip to content

Consider renaming theme on createSurface to configuration and remove primaryColor from basic catalog #1118

@jacobsimionato

Description

@jacobsimionato

I'm wondering if we should remove agent-driven theming because:

  • We haven't seen great uptake so far
  • It complicates implementing Components, when there is programmatic styling configuration and JSON theming configuration
  • Creates a confusing mental model where Components are not really independent from the Catalog that owns them, because their implementation could be coupled to the Catalog's theme structure.
  • Other competitors in this space don't have this concept

I think having some type of immutable surface-level config is still helpful, potentially just to include the agent name, logo etc.

Proposal

  1. Rename theme to configuration but keep the way it works exactly the same. We will just be allowing catalog designers to specify the structure of some surface-specific information which could be anything, but we aren't suggesting that there should be surface-level theming.

  2. Remove primaryColor from the basic catalog configuration, but preserve iconUrl and agentDisplayName, which are really configuration parameters anyway.

This still leaves the door open for people to create catalogs which have surface-level agent-driven theming if they want to, but we background that direction and simplify the basic catalog.

Metadata

Metadata

Assignees

Type

No type

Projects

Status

Todo

Relationships

None yet

Development

No branches or pull requests

Issue actions