Discrepancy between Angular catalog implementation and specification props

[josemontespg]

There is a discrepancy between what the Angular component implementations in the basic catalog support in props in the actual implementation, and what the JSON specifications support.

We need to decide whether to add these properties to the spec, or to remove support for the properties on the component implementation.

Here are the properties with a discrepancy:

• Icon: color
  • Implementation: icon.component.ts
• TextField: placeholder
  • Implementation: text-field.component.ts
• Video: posterUrl
  • Implementation: video.component.ts

Source of Truth for JSON Spec: basic_catalog.json

CC: @gspencergoog, @ditman

[gspencergoog]

It seems like we should add these to the v0.10 spec and remove them from the angular renderer for now until we start supporting v0.10, so that we can have parity between the renderers.

Alternatively, we can add it to v0.9 spec and implement them for all the other renderers.

I'm a little leery of adding icon color to the spec though: we have literally no other colors in the spec. I'd rather it were a "variant" field for the Icon that says the variant of icon it is ("alert", "important", "success", etc.), and have that determine the color in the renderer. Determining a reasonable set of variants might be hard, though.

[josemontespg]

I agree to remove them from the 0.9 angular renderer now to get it consistent.

I think we should add placeholder and posterUrl to the v0.10 spec, since these properties map directly to HTML attributes, and are essential to the TextField and Video components. I can do this if we are in agreement.

For the icon color property, I think it makes sense for clients to customize this using css overrides, --a2ui-icon-color already exists. I propose to not include icon color in the v0.10 spec.

What do you think?