toSnakeCase is repeated across multiple implementations

[ava-cassiopeia]

It's a small thing, but we might want to just have one implementation that they all import.

[MasterOogway1466]

Can I take up this issue?

[ava-cassiopeia]

@MasterOogway1466 by all means! Note that there is an instance of toSnakeCase in #679, so you may need to patch that into that PR.

[ava-cassiopeia]

and #382 actually 😅

I also wouldn't blame you if you wanted to wait until those are merged and then do this.

[MasterOogway1466]

@ava-cassiopeia I think I'll just wait until those PRs are merged before getting started 😅. I'm new to open source contributions and I'd like to know if there's a way to get a notification once the mentioned issues are closed or is my only option to check in manually regarding their status?

[ava-cassiopeia]

Reasonable!

Sadly, there's not a perfect way, at least not without finding some 3rd party tool (of which I know little).

You can subscribe to the PRs, which will notify you when they are merged...and also for just about anything else that happens, including the author making additional commits, comments, etc. So, it's noisy but if you're willing to deal with the noise in your github inbox, you will eventually get notified about it.

I will try to come back and ping this bug when those merge, if I remember, but my memory is not made of silicon (...yet?), so I wouldn't rely on that notification method 😅

[MasterOogway1466]

Got it lmao, I'll subscribe to the issues you've mentioned 👍 . Also potentially silly question, I'm unable to find any instances of 'toSnakeCase' in the codebase. I'm currently looking at the main branch, am i supposed to be working on a different branch or am I doing something wrong 😅 ?

[ava-cassiopeia]

So, it's subtle because the lede is a bit buried here.

In the Lit renderer, it is here (unnamed, but same functionality)
In the React renderer, it is here (but of course, not merged, so won't show up in search)
In the Svelte renderer, it is here (same as above)

The Angular renderer does not do this in its Icon impl but it should.

The benefit is illustrated pretty nicely here too: we're inconsistent with its usage and the usage of toLocaleLowerCase() vs. toLowerCase().

[ava-cassiopeia]

I probably should've included those details in the initial issue, but frankly I didn't expect anyone to jump in (at all|so quickly), so kudos!