Skip to content

(Angular) Style widgets using CSS variables.#1166

Merged
ditman merged 11 commits intogoogle:mainfrom
ditman:core-styling-angular
Apr 14, 2026
Merged

(Angular) Style widgets using CSS variables.#1166
ditman merged 11 commits intogoogle:mainfrom
ditman:core-styling-angular

Conversation

@ditman
Copy link
Copy Markdown
Collaborator

@ditman ditman commented Apr 13, 2026

Description

This PR adds styling based on CSS variables to the components of the basic catalog of the Lit renderer.

The PR uses the base styles defined in web_core, and adds per-component overrides that can be used to customize the appearance of each component further.

Testing

  • Tested manually by running npm run demo in the angular renderer directory.

Pre-launch Checklist

If you need help, consider asking for advice on the discussion board.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements a comprehensive theming refactor for the v0.9 basic catalog components across both Angular and Lit renderers, replacing hardcoded styles with a system of CSS variables. Key changes include the introduction of a base class for Lit components to handle style injection, the removal of the minimal catalog, and standardized layout mapping for Row and Column components. Review feedback highlights several areas for improvement, including the removal of as any type assertions, addressing potential style leakage from global encapsulation in Angular, deduplicating layout constants, and resolving inconsistencies in icon naming logic and documentation between the two frameworks.

@ditman
Copy link
Copy Markdown
Collaborator Author

ditman commented Apr 13, 2026

(Please ignore anything outside renderers/angular, that's part of a previous PR but stacking is not great)

@ditman ditman force-pushed the core-styling-angular branch from decc1e6 to e5827f7 Compare April 14, 2026 02:59
@ditman ditman force-pushed the core-styling-angular branch from e5827f7 to 2e18a2b Compare April 14, 2026 06:07
@ditman ditman merged commit 7475a3f into google:main Apr 14, 2026
6 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in A2UI Apr 14, 2026
@ditman ditman deleted the core-styling-angular branch April 14, 2026 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants