(Angular) Style widgets using CSS variables.#1166
Conversation
There was a problem hiding this comment.
Code Review
This pull request implements a comprehensive theming refactor for the v0.9 basic catalog components across both Angular and Lit renderers, replacing hardcoded styles with a system of CSS variables. Key changes include the introduction of a base class for Lit components to handle style injection, the removal of the minimal catalog, and standardized layout mapping for Row and Column components. Review feedback highlights several areas for improvement, including the removal of as any type assertions, addressing potential style leakage from global encapsulation in Angular, deduplicating layout constants, and resolving inconsistencies in icon naming logic and documentation between the two frameworks.
|
(Please ignore anything outside renderers/angular, that's part of a previous PR but stacking is not great) |
decc1e6 to
e5827f7
Compare
e5827f7 to
2e18a2b
Compare
Description
This PR adds styling based on CSS variables to the components of the basic catalog of the Lit renderer.
The PR uses the base styles defined in web_core, and adds per-component overrides that can be used to customize the appearance of each component further.
Testing
npm run demoin the angular renderer directory.Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.