refactor(spec): clean up all remaining references to basic_catalog.json#1463
Merged
Conversation
910f83e to
94b2786
Compare
…talogs/basic/catalog.json Complete the cleanup of basic_catalog.json legacy references by renaming them to catalogs/basic/catalog.json in v0.9 and v0.10 specifications, SDKs (Python/Kotlin), demo samples, test cases, and eval runners.
94b2786 to
72c42ce
Compare
4 tasks
suyangw-g
pushed a commit
to suyangw-g/A2UI
that referenced
this pull request
May 26, 2026
…on (google#1463) Complete the cleanup of basic_catalog.json legacy references by renaming them to catalogs/basic/catalog.json in v0.9 and v0.10 specifications, SDKs (Python/Kotlin), demo samples, test cases, and eval runners.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow-on to commit
e2053fff00fb30972c60d9604511f9cfa15890a7(#1452) to clean up all remaining references to the legacybasic_catalog.jsonschema, re-targeting them to the newly restructured catalog path atcatalogs/basic/catalog.json.Changes
eval/):specification/v0_9/eval/src/index.tsandspecification/v0_10/eval/src/index.tsto resolve and key specification schemas relative to the version root using their repository path (e.g.catalogs/basic/catalog.json).eval/src/validator.tsto replace references to'basic_catalog.json'with'catalogs/basic/catalog.json'.eval/src/generation_flow.tsto use the correct restructured catalog URL.test/):run_tests.pytest suite scripts inv0_9/test/andv0_10/test/to point to the new catalog file path by default.v0_10/test/run_tests.pyrelative toSPEC_DIR, completely removing the legacy fallback array mapping.contact_form_example_test.json,contact_form_example.jsonl, andtheme_validation.json).build.gradle.ktsand resource mappings inBasicCatalogProvider.kt/ValidatorTest.ktto referencecatalog.jsoninsidespecification/v0_9/catalogs/basic/.test_catalog.py,test_validator.py, andverify_load_real.pyto usecatalogs/basic/catalog.json.samples/to migrate theircatalogIdfield.renderers/angular/scripts/generate-examples.mjs.Impact & Risks
There are no breaking changes or performance side effects. The remappings are backward-compatible and resolve the exact same JSON schema files under their restructured names.
Testing
uv run pytestinsideagent_sdks/pythonto verify all 248 unit and integration tests execute and pass.python3 run_tests.pyinsidespecification/v0_9/test/andspecification/v0_10/test/respectively.