Align runtime validation behavior with v0.8 schema expectations for bindable fields#1476
Open
selamw1 wants to merge 3 commits into
Open
Align runtime validation behavior with v0.8 schema expectations for bindable fields#1476selamw1 wants to merge 3 commits into
selamw1 wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the validation logic in the common types schema to allow at least one property instead of requiring exactly one. This change is applied to several schemas including StringValue, NumberValue, and BooleanValue. The review feedback identifies a logic mismatch in the DataValueMapItemSchema where the condition still checks for exactly one property despite the updated error message, and points out an outdated description string in the ActionSchema that needs to be updated for consistency.
0c1515a to
1e3df2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses a runtime validation regression introduced in newer
@a2ui/reactversions when validating spec-compliant A2UI v0.8 payloads.In
@a2ui/react@0.8.0, bindable fields (such asMultipleChoice.selections) containing bothpathand a literal fallback (e.g.,literalArray) were correctly validated, matching the official A2UI v0.8 catalog specification. Later releases introduced a strict refinement (exactlyOneKey) that failed at runtime withMust define exactly one property.This PR replaces
exactlyOneKeywithatLeastOneKeyfor v0.8 bindable properties in@a2ui/web_core. This aligns runtime validation behavior with official v0.8 schema expectations while preserving backwards compatibility for producers emitting both data bindings and literal initial values.Fixes: #1469
Pre-launch Checklist