Fix test imports, add !, and restore OnPush change detection#1481
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the node:assert imports and adds non-null assertion operators in test files. The reviewer identified a violation of the repository's style guide regarding the PR description checklist and suggested a refactor to improve code consistency and readability.
…revert components/samples back to OnPush
josemontespg
changed the title
| }) | ||
| .overrideComponent(Card, { | ||
| set: { | ||
| changeDetection: ChangeDetectionStrategy.Default, |
There was a problem hiding this comment.
Wasn't the problem of this change that the google3 defaults are different than the open source ones?
There was a problem hiding this comment.
The problem is that ChangeDetectionStrategy.Default does not exist in google3. Only Eager and OnPush.
These tests don't really need to override the change detection, so we can just remove these.
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
LGTM! Good luck with the OnPush!
…1481) * Fix test imports and add ! to fix 1P roll * Use ChangeDetectionStrategy.Eager in tests * test(angular): remove ChangeDetectionStrategy overrides in tests and revert components/samples back to OnPush * Fix failing PR actions: format Spec files after removing ChangeDetectionStrategy overrides
2 participants
Fixes test imports to use namespace imports, adds non-null assertions (!) to restore successful compilation and passing tests under 1P / google3 environment, and removes ChangeDetectionStrategy overrides in tests while restoring components/samples to OnPush.