Revert #515 and modify stringFormat to take named args. #573
+316
−201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gspencergoog
force-pushed
the
named_parameters
branch
from
3794ecc to
9df90d1
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
gspencergoog
force-pushed
the
named_parameters
branch
7 times, most recently
from
7593cbd to
41641af
Compare
gspencergoog
force-pushed
the
named_parameters
branch
from
41641af to
b1a92c5
Compare
gspencergoog
changed the title
jacobsimionato
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts #515 and instead of making the args be positional, have them be named, modifying the stringFormat format string so that its function call syntax also includes names. This is to open the door to better function call validation.
I also fixed some failures in the evals due to the catalog aliasing change.
cc @jgindin