Skip to content

Conversation

@shantoislamdev
Copy link
Contributor

Description

This PR fixes two critical bugs in the Lit MultipleChoice component that prevented proper HTML rendering and state reflection.

Issues Fixed:

  1. Invalid HTML attribute binding: Options were rendered as <option valueContent> instead of <option value="valueContent">.
  2. Missing state reflection: The dropdown did not display the currently selected value from the model.

Changes:

  • Fixed option value binding to use standard HTML syntax: value="${option.value}".
  • Added .value property binding to the <select> element to reflect the current selection from this.selections.

This brings the Lit implementation into alignment with the Angular renderer, which correctly handles these cases.

Fixes #574

Testing

  • Tests pass: 23/23 ✅
  • Verified HTML output renders correct value attributes
  • Verified dropdown reflects model state

Checklist

  • I have signed the Google CLA
  • My code follows the project's style guidelines
  • I have tested my changes locally

@gemini-code-assist
Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

[BUG] Lit MultipleChoice component has broken HTML binding and state reflection

1 participant