[angular] Use ChangeDetectionStrategy.OnPush for components#805
Closed
ditman wants to merge 3 commits intogoogle:mainfrom
Closed
[angular] Use ChangeDetectionStrategy.OnPush for components#805ditman wants to merge 3 commits intogoogle:mainfrom
ditman wants to merge 3 commits intogoogle:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request changes the change detection strategy to OnPush for many Angular components, which can improve performance. It also modifies a package.json script to run npm install. My feedback includes a point about the developer experience impact of the script change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR sets the ChangeDetectionStrategy of the Angular renderer components to OnPush to match that of the internal version.
(This was requested by @jgindin on cl/878208726)
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.