Tweak v0.8 Button and TextField schemas to better match the spec.#806
Merged
ditman merged 3 commits intogoogle:mainfrom Mar 10, 2026
Merged
Tweak v0.8 Button and TextField schemas to better match the spec.#806ditman merged 3 commits intogoogle:mainfrom
ditman merged 3 commits intogoogle:mainfrom
Conversation
* Adds Button.primary (optional boolean) * Renames TextField.type to TextField.textFieldType These changes are required to better match the spec.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the schemas for Button and TextField to better align with the v0.8 spec, adding a primary property to Button and renaming type to textFieldType for TextField. The changes are propagated through the web_core, Angular, and Lit renderers. My review focuses on the implementation of these changes in the renderer components. While the schema and property bindings are updated correctly, the UI logic in both Angular and Lit renderers for these new properties is incomplete. I've left comments with suggestions on how to fully implement the functionality for Button's primary state and TextField's various textFieldType options.
gspencergoog
approved these changes
Mar 10, 2026
jacobsimionato
approved these changes
Mar 10, 2026
jgindin
approved these changes
Mar 10, 2026
lukasmoschitz
added a commit
to CopilotKit/A2UI
that referenced
this pull request
Mar 12, 2026
web_core 0.8.4 renames TextField's `type` to `textFieldType` (google#806). Pin until the React renderer is updated to match (google#810).
3 tasks
ava-cassiopeia
pushed a commit
that referenced
this pull request
Mar 12, 2026
* Fix visual parity Lit harness broken after merge The Lit harness stopped rendering after the merge because: 1. @a2ui/markdown-it was pinned to ^0.0.1 (npm registry) which has a synchronous renderMarkdown(). After commit b904548 made MarkdownRenderer async, the Lit directive calls .then() on the result, causing "markdownRenderer(...).then is not a function". Fix: switch to file:../../markdown/markdown-it to stay in sync with the local source (now async, v0.0.2). 2. The React Vite dev server lazily discovers @a2ui/web_core subpath imports, triggering "optimized dependencies changed. reloading" mid-page-load which causes blank screenshots in Playwright. Fix: add web_core subpath imports to optimizeDeps.include so Vite pre-bundles them upfront. * Pin @a2ui/web_core to <0.8.4 to avoid TextField breakage web_core 0.8.4 renames TextField's `type` to `textFieldType` (#806). Pin until the React renderer is updated to match (#810). * Add minimum version floor to @a2ui/web_core dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a small discrepancy between the v0.8 spec and the schema for
Buttons andTextFields.(Discovered in cl/878208726)
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.