Revert Change CallId to allow for more data. (#793)#880
Merged
jgindin merged 1 commit intogoogle:mainfrom Apr 14, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request reverts the structure of CallId from an object back to a string, simplifying the specification. It also introduces a new optional call property to functionResponse for better logging. The changes to the specification and the updates to existing test cases to reflect the CallId change are well-executed. My only feedback is regarding test coverage for the newly added call property, as detailed in my comment.
After further discussion, we decided that the use case for passing the agent could be solved in a better way. We're adding the `call` property to the `functionResponse` as we believe that will be useful for logging purposes.
jgindin
force-pushed
the
server-initiated-functions
branch
from
12045da to
4f0eb39
Compare
jacobsimionato
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After further discussion, we decided that the use case for passing the agent could be solved in a better way.
We're adding the
callproperty to thefunctionResponseas we believe that will be useful for logging purposes.Pre-launch Checklist