This repository was archived by the owner on Dec 29, 2022. It is now read-only.
[spirv] fix sorting DebugTypeTemplateParam bug#317
Merged
jaebaek merged 1 commit intogoogle:debug_infofrom Jun 8, 2020
Merged
Conversation
We emit DebugInfoNone for Value operand of DebugTypeTemplateParam when DebugTypeTemplateParam is used for a type, not a value. Previously, we did not consider the case in SortDebugInfoVisitor.
ehsannas
approved these changes
Jun 8, 2020
|
✅ Build DirectXShaderCompiler 1.0.443 completed (commit fb089b3ebd by @jaebaek) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We emit DebugInfoNone for Value operand of DebugTypeTemplateParam
when DebugTypeTemplateParam is used for a type, not a value. Previously,
we did not consider the case in SortDebugInfoVisitor.
Fixes #311