Don't cache if caching not allowed in Cache-Control HTTP header

[starchey]

Issue description

Playing live HLS stream causes audioTrackUnderrun error, playback stops, and throws PlaylistStuckException (source error).

Reproduction steps

Launch video. Playback will proceed normally for ~10 seconds and then start to stutter and eventually stop.

Link to test content

Emailed.

Version of ExoPlayer being used

dev-v2 branch, commit #d4eb2e5b8571f57169126a155c98af775f14b4ad

Device(s) and version(s) of Android being used

• Samsung S6 Edge Plus running 6.0.1
• Nexus 9 Tablet running 6.0
• HTC One running 5.0.1

A full bug report captured from the device

Emailed.

[starchey]

I just realized this is happening because I'm using CacheDataSourceFactory, which serves no purpose for our live stream (I just had the code in place for all video plays). If I setup my media source as follows, the issue goes away:

videoSource = new HlsMediaSource.Factory(mediaDataSourceFactory) .createMediaSource(Uri.parse(url), mainHandler, eventLogger);

I was running into the issue with the following setup (so I'm just no longer using the Cache on the live stream):

SimpleCache cache = new SimpleCache(cacheDir, new NoOpCacheEvictor()); HlsMediaSource.Factory factory = new HlsMediaSource.Factory(new CacheDataSourceFactory(cache, mediaDataSourceFactory, CacheDataSource.FLAG_BLOCK_ON_CACHE)); videoSource = factory.createMediaSource(Uri.parse(url), mainHandler, eventLogger);

[AquilesCanta]

If the media playlist gets cached, then PlaylistStuckException would mean ExoPlayer is working as intended. After seeing no changes in a live playlist, the player assumes there is an issue server-side. @erdemguven, is there an issue tracking the use of HTTP response headers to control what can be cached? If not, we can use this. Otherwise, this can be closed I think.

[kgrevehagen]

@erdemguven Are there any progress or ETA on this? I'm very interested in getting this functionality.

[marcbaechinger]

Sorry, we don't have an ETA for this right now.

[greyski]

Hi! Just wanted to bump this up. Spent a good day and a half trying to understand why our ExoPlayer implementation wouldn't run live streams save for a few seconds before erring out.

I can confirm using DefaultMediaSourceFactory(CacheDataSource.Factory()) will prevent streams from playing past ~10 seconds as mentioned by OP. Could we at least update the wiki page about these findings until we have a working solution/workaround?

[julianD77]

The solution in our case was simply to do as detailed by @starchey above and not use a caching DataSource