Fix VP9 color space parsing in MP4 atom parser#11064
Closed
haixia-meta wants to merge 2 commits intogoogle:release-v2from
Closed
Fix VP9 color space parsing in MP4 atom parser#11064haixia-meta wants to merge 2 commits intogoogle:release-v2from
haixia-meta wants to merge 2 commits intogoogle:release-v2from
Conversation
This adds vpcC atom parsing based on the open-source FFmpeg implementation (https://github.com/FFmpeg/FFmpeg/blob/master/libavformat/vpcc.c#L213) This fix is needed to have correct color space parsing in vpcC atom because Instagram serves HDR VP9 encodings in MP4 containers.
rohitjoins
reviewed
Mar 15, 2023
Contributor
rohitjoins
left a comment
rohitjoins
left a comment
There was a problem hiding this comment.
Thank you for the contribution.
library/extractor/src/main/java/com/google/android/exoplayer2/extractor/mp4/AtomParsers.java
Outdated
Show resolved
Hide resolved
library/extractor/src/main/java/com/google/android/exoplayer2/extractor/mp4/AtomParsers.java
Outdated
Show resolved
Hide resolved
Contributor
|
Thanks for updating. Will merge this soon. |
rohitjoins
added a commit
that referenced
this pull request
Mar 16, 2023
PiperOrigin-RevId: 517128752
Contributor
|
This was merged into Note: Development work is done in the |
rohitjoins
added a commit
that referenced
this pull request
Apr 18, 2023
PiperOrigin-RevId: 517128752 (cherry picked from commit d88dd74)
icbaker
pushed a commit
that referenced
this pull request
Apr 27, 2023
PiperOrigin-RevId: 517128752 (cherry picked from commit 0e3f407)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds VP9 color space parsing in MP4 vpcC atom.
Please refer to VP9 MP4 atom syntax documentation: https://www.webmproject.org/vp9/mp4/#syntax_1
This fix is needed to have correct color space parsing in vpcC atom because Instagram serves HDR VP9 encodings in MP4 containers.